-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers #82321
Disable System.Reflection.Tests.TypeDelegatorTests.FunctionPointers #82321
Conversation
Disable this failing test on CoreCLR. Tracking: dotnet#82252
/azp run runtime-coreclr libraries-jitstress |
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsDisable this failing test on CoreCLR. Tracking: #82252
|
Azure Pipelines successfully started running 1 pipeline(s). |
@dotnet/jit-contrib PTAL -- want to get a clean libraries stress pipeline |
It looks like the "jitstress" tests are successful but there's still other failures -- so was disabling that test successful here? |
#82325 has the actual fix for the problem. If this is the only failing test, I am ok with disabling the test before the actual fix is merged. Note that the failure only repros with tiered compilation disabled, or when the affected code is promoted to Tier 1. |
I'd prefer to disable the test when this testing completes, then you can re-enable either with your fix or afterwards, after also running a clean libraries-jitstress pipeline. fwiw, we should probably add a TieredCompilation=0 run to all libraries changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the real fix goes in, I'll revert this. Thanks
I agree that it would be nice, but it is not where we are going with PR CI. We do not have enough budget to test all variants in PR CI. We are on a path to do less testing in PR CI and allow more issues to slip through that are only going to be found later in rolling runs. |
I've wondered whether the libraries tests PR testing should be TieredCompilation=0 and the outerloop rolling should be the default TieredCompilation=1. I wonder how many of the functions executed during libraries tests are compiled in Tier-0 versus Tier-1. It probably doesn't matter to the libraries team, but for the JIT team it does matter. |
…inters (dotnet#82321)" This reverts commit 473e278.
Disable this failing test on CoreCLR.
Tracking: #82252