-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose missing BinaryPrimitives APIs #82310
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-buffers Issue DetailsThis resolves #72107
|
Is there anywhere we should be using these? |
I'm not aware of any places where we're using Looks like we can switch to using |
...libraries/System.Private.CoreLib/src/System/Buffers/Binary/BinaryPrimitives.ReadBigEndian.cs
Outdated
Show resolved
Hide resolved
3340ac9
to
0cedabc
Compare
Fixed the docs and updated relevant places to use the new BinaryPrimitives APIs where applicable. |
Failure is #82055, this can be merged once it gets sign-off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any specific logic in the tests that could use a deeper pass? Also, will we want these APIs on the new Decimal types?
None come to mind. These are relatively straightforward APIs.
Probably not without explicit user ask. Users can achieve the same thing by reading the raw bits and calling |
This resolves #72107