Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: don't optimize calls to CORINFO_HELP_VIRTUAL_FUNC_PTR for interface class lookups #82209

Merged
merged 5 commits into from
Feb 23, 2023
Merged

JIT: don't optimize calls to CORINFO_HELP_VIRTUAL_FUNC_PTR for interface class lookups #82209

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5d98d7
JIT: don't optimize calls to CORINFO_HELP_VIRTUAL_FUNC_PTR
AndyAyersMS Feb 15, 2023
4971a05
Revert "JIT: don't optimize calls to CORINFO_HELP_VIRTUAL_FUNC_PTR"
AndyAyersMS Feb 16, 2023
32d3ea2
revise to keep the opt for virtual class cases
AndyAyersMS Feb 16, 2023
3e1ef29
Merge remote-tracking branch 'upstream/main' into Fix82127
AndyAyersMS Feb 18, 2023
2007865
fix flag setting
AndyAyersMS Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7802,25 +7802,6 @@ GenTree* Compiler::fgMorphCall(GenTreeCall* call)
#endif
}

if ((call->gtCallMoreFlags & GTF_CALL_M_SPECIAL_INTRINSIC) == 0 &&
(call->gtCallMethHnd == eeFindHelper(CORINFO_HELP_VIRTUAL_FUNC_PTR)
#ifdef FEATURE_READYTORUN
|| call->gtCallMethHnd == eeFindHelper(CORINFO_HELP_READYTORUN_VIRTUAL_FUNC_PTR)
#endif
) &&
(call == fgMorphStmt->GetRootNode()))
{
// This is call to CORINFO_HELP_VIRTUAL_FUNC_PTR with ignored result.
// Transform it into a null check.

assert(call->gtArgs.CountArgs() >= 1);
GenTree* objPtr = call->gtArgs.GetArgByIndex(0)->GetNode();

GenTree* nullCheck = gtNewNullCheck(objPtr, compCurBB);

return fgMorphTree(nullCheck);
}

noway_assert(call->gtOper == GT_CALL);

//
Expand Down