-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corehost: derive fallback rid from output rid. #82163
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsFixes #81654. This is a start. It handles non-portable non-Windows. I wonder if we need a separate path to handle portable, or if this should work as-is. I need some help with updating the Windows scripts. I can figure some things out by copy-pasting, but I don't know how to strip the architecture from the @vitek-karas @elinor-fung @ViktorHofer @am11 ptal.
|
:: batch script - test.cmd
set __OutputRid=win10-arm64
for /f "delims=-" %%i in ("%__OutputRid%") do set __FallbackOS=%%i
echo %__FallbackOS% outputs: |
397708a
to
445d8af
Compare
8e9b96c
to
c490ee5
Compare
CI is looking good for these changes. Portable and non-portable share the same logic. Also, the Windows has the same logic as the Unix script. @vitek-karas @elinor-fung this is up for review. |
I've addressed the feedback, and CI looks happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
And thank you and @am11 for reviewing! |
Fixes #81654.
This is a start. It handles non-portable non-Windows.
I wonder if we need a separate path to handle portable, or if this should work as-is.
I need some help with updating the Windows scripts. I can figure some things out by copy-pasting, but I don't know how to strip the architecture from the
__OutputRid
.@vitek-karas @elinor-fung @ViktorHofer @am11 ptal.