Add CollectionsMarshal.SetCount(list, count) #82146
Conversation
Adds the ability to resize lists, exposed in CollectionsMarshal due to potentially risky behaviour caused by the lack of element initialization. Supersedes dotnet#77794. Fixes dotnet#55217.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsAdds the ability to resize lists, exposed in Supersedes #77794. Fixes #55217.
|
|
@stephentoub to see if you still have any open questions. |
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/CollectionsMarshal.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/CollectionsMarshal.cs
Show resolved
Hide resolved
|
@MichalPetryka could you take a look at the latest review feedback please? Thanks. |
eiriktsarpalis
added
the
needs-author-action
Ah sorry, sure, forgot about this. |
ghost
removed
the
needs-author-action
....Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/CollectionsMarshalTests.cs
Show resolved
Hide resolved
| static void SequenceEquals<T>(ReadOnlySpan<T> actual, ReadOnlySpan<T> expected) | ||
| { | ||
| Assert.Equal(actual.Length, expected.Length); | ||
|
|
||
| for (int i = 0; i < actual.Length; i++) | ||
| { | ||
| Assert.Equal(actual[i], expected[i]); | ||
| } | ||
| } |
There was a problem hiding this comment.
There's already a helper for this in AssertExtensions:
ghost
locked as resolved and limited conversation to collaborators
Adds the ability to resize lists, exposed in
CollectionsMarshal due to potentially risky
behaviour caused by the lack of element initialization.
Supersedes #77794.
Fixes #55217.