Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector's Narrow intrinsics #81843

Merged
merged 1 commit into from
Feb 9, 2023

Commits on Feb 8, 2023

  1. Fix vector's Narrow intrinsics

    The BCL Vector classes have non-saturating Narrow methods, while wasm
    instructions are saturating. AFAIK wasm doesn;t have non-saturating
    narrow instructions. So instead of using
    
        i8x16.narrow_i16x8_s
        i8x16.narrow_i16x8_u
        i16x8.narrow_i32x4_s
        i16x8.narrow_i32x4_u
    
    instructions, use `v8x16.shuffle` instruction to implement the extract
    narrow operation.
    
    This fixes `System.Numerics.Tests.GenericVectorTests.Narrow[U]Int*`
    tests.
    radekdoulik committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    77f23db View commit details
    Browse the repository at this point in the history