-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evaluate-default-paths.yml: Add paths for wasi #81817
Conversation
.. and exclude wasm specific paths from coreclr.
Tagging subscribers to this area: @directhex Issue Details.. and exclude wasm specific paths from coreclr.
|
@@ -7,9 +7,13 @@ parameters: | |||
_const_paths: | |||
_wasm_specific_only: [ | |||
eng/testing/ProvisioningVersions.props | |||
eng/testing/Was*Runner* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(m|i)
instead of *
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or use ?
to be clear that it's one character
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the caveat that i don't know what kind of glob/regex syntax is being used here :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. these are used with git diff
, and follow git pathspec
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmph azdo didn't like ?
: /eng/pipelines/common/evaluate-default-paths.yml (Line: 10, Col: 24): While parsing a flow sequence, did not find expected ',' or ']'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took the easy way out with WasmRunner*
, and WasiRunner
.
@@ -4,6 +4,7 @@ parameters: | |||
isWasmOnlyBuild: false | |||
browser: 'chrome' | |||
shouldContinueOnError: false | |||
runOnlyOnWasmPipelines: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to why this would want to run on non-wasm pipelines. Are the wasm debugger tests not a wasm pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should really be named runOnlyOnWasmOnlyPipelines
or such!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, it should run only on runtime-wasm* pipelines which have only wasm builds, and are run manually.
Using `Was?Runner*` failed to validate on azdo with: `/eng/pipelines/common/evaluate-default-paths.yml (Line: 10, Col: 24): While parsing a flow sequence, did not find expected ',' or ']'.`
This is a CI only change, and the failures are unrelated. |
.. and exclude wasm specific paths from coreclr.
runtime
pipeline