[wasm][debugger] Skip wasm frames if just my code is enabled #81732
Conversation
…stmycode is enabled.
|
Tagging subscribers to this area: @thaystg Issue DetailsTrying to avoid stepping out when there is no source available and justmycode is enabled. Trying to fix this: https://stackoverflow.com/questions/74972911/blazor-wasm-debug-stops-with-frame-not-in-module Callstack without the PR: Callstack with the PR and JustMyCode enabled: Callstack with the PR and JustMyCode disabled: Stepping out without the PR, and you user can step out forever, it has a lot of calls. Stepping out with the PR - will behavior like a resume.
|
…uld be skipped is the last in the callstack.
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -198,6 +198,22 @@ protected override async Task<bool> AcceptEvent(SessionId sessionId, JObject par | |||
| await SendResume(sessionId, token); | |||
| return true; | |||
| } | |||
| case "mono_wasm_fire_debugger_agent_message_with_data": | |||
| case "_mono_wasm_fire_debugger_agent_message_with_data": | |||
There was a problem hiding this comment.
How does _mono_wasm_fire_debugger_agent_message_with_data originate and can't we force to have only e.g. mono_wasm_fire_debugger_agent_message_with_data?
There was a problem hiding this comment.
Never mind, I just noticed all the cases are in this convention.
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Trying to avoid stepping out when there is no source available and justmycode is enabled.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1733523
Trying to fix this: https://stackoverflow.com/questions/74972911/blazor-wasm-debug-stops-with-frame-not-in-module
Callstack without the PR:
Callstack with the PR and JustMyCode enabled:
Callstack with the PR and JustMyCode disabled:
Stepping out without the PR, and you user can step out forever, it has a lot of calls.
Stepping out with the PR - will show pause in the JS functions.
TODO - Find a way to detect if it's a function from framework (dotnet.js/blazor.webassembly.js/browserLink) and skip them if JustMyCode is enabled.