Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Fix conditions to bin place msquic.dll for Windows builds #81490

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Feb 1, 2023

Fixes #81447

@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #81447

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

@ManickaP
Copy link
Member Author

ManickaP commented Feb 1, 2023

/backport to release/8.0-preview1

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Started backporting to release/8.0-preview1: https://github.com/dotnet/runtime/actions/runs/4067211785

@karelz karelz added this to the 8.0.0 milestone Feb 1, 2023
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP ManickaP force-pushed the mapichov/quic-fix-win branch from 04e4af3 to ddf21b8 Compare February 1, 2023 17:55
@ManickaP
Copy link
Member Author

ManickaP commented Feb 1, 2023

/backport to release/8.0-preview1

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Started backporting to release/8.0-preview1: https://github.com/dotnet/runtime/actions/runs/4067254031

@carlossanlop
Copy link
Member

CI green. :shipit:

@carlossanlop carlossanlop merged commit afc81dd into main Feb 1, 2023
@carlossanlop carlossanlop deleted the mapichov/quic-fix-win branch February 1, 2023 20:21
@ViktorHofer
Copy link
Member

@ManickaP thanks for fixing my mistake and adding a test to make sure this doesn't regress again in the future.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msquic.dll is no longer included in the Windows shared runtime
5 participants