Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't clone a large tree in impRuntimeLookupToTree #81472

Closed
wants to merge 4 commits into from
Closed

Don't clone a large tree in impRuntimeLookupToTree #81472

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc3b9ef
Don't clone a large tree in impRuntimeLookupToTree
EgorBo Feb 1, 2023
8e3a496
Merge branch 'main' of github.com:dotnet/runtime into jit-tp-clone-nc
EgorBo Feb 5, 2023
1ba2515
Update importer.cpp
EgorBo Feb 6, 2023
22b61ad
minimize regressions
EgorBo Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,12 +1890,15 @@ GenTree* Compiler::impRuntimeLookupToTree(CORINFO_RESOLVED_TOKEN* pResolvedToken
// Call the helper
// - Setup argNode with the pointer to the signature returned by the lookup
GenTree* argNode = gtNewIconEmbHndNode(pRuntimeLookup->signature, nullptr, GTF_ICON_GLOBAL_PTR, compileTimeHandle);

GenTreeCall* helperCall = gtNewHelperCallNode(pRuntimeLookup->helper, TYP_I_IMPL, ctxTree, argNode);

// handleForNullCheck is used for both nullcheck and as a return value. The tree is a bit verbose so we'd better
// save it to a local to make IR smaller. Although, the local leads to undesired size regression in MinOpts
GenTree* handleForResult =
opts.OptimizationEnabled() ? fgInsertCommaFormTemp(&handleForNullCheck) : gtCloneExpr(handleForNullCheck);
Comment on lines +1897 to +1898
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a comma here? Can we create a new statement given that we are in the importer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, will check!


// Check for null and possibly call helper
GenTree* nullCheck = gtNewOperNode(GT_NE, TYP_INT, handleForNullCheck, gtNewIconNode(0, TYP_I_IMPL));
GenTree* handleForResult = gtCloneExpr(handleForNullCheck);
GenTree* nullCheck = gtNewOperNode(GT_NE, TYP_INT, handleForNullCheck, gtNewIconNode(0, TYP_I_IMPL));

GenTree* result = nullptr;

Expand Down