Introduce AOT friendly version of ToLogFont and FromLogFont #81082
Conversation
These methods used by WinForms Closes #70358
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-drawing Issue DetailsThese methods used by WinForms
|
|
@kant2002 can you please add tests for the new APIs? |
|
cc: @JeremyKuhne |
| @@ -291,6 +291,29 @@ public unsafe void ToLogFont(object logFont, Graphics graphics) | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Update the given LOGFONT with data from given graphics. | |||
There was a problem hiding this comment.
It would be better to use the wording in the existing docs. This applies to all of the overloads you're adding.
| @@ -888,6 +1039,25 @@ public class LOGFONT | |||
| public string lfFaceName; | |||
| } | |||
|
|
|||
| [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)] | |||
| public struct LOGFONT_Struct | |||
There was a problem hiding this comment.
Probably unnecessary. You're inadvertently using this (incorrect) struct in the positive tests. Just using an existing struct (say, Point) should be sufficient for the negative tests.
| using (FontFamily family = FontFamily.GenericMonospace) | ||
| { | ||
| IntPtr lpFaceName = Marshal.StringToCoTaskMemAuto(family.Name); | ||
| var logFont = new LOGFONT_Struct |
There was a problem hiding this comment.
LOGFONT_Struct isn't a valid definition of LOGFONT.
ghost
added
the
needs-author-action
|
@kant2002 we just recently migrated System.Drawing.Common to dotnet/winforms and need to port this PR over to winforms. cc @JeremyKuhne |
ghost
locked as resolved and limited conversation to collaborators
These methods used by WinForms
Closes dotnet/winforms#8846