Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Lemire's nearly divisionless method #79790

Merged
merged 32 commits into from
Feb 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c5dadb4
Lemire implementation
mla-alm Dec 15, 2022
71b3bb3
Cleanup
mla-alm Dec 17, 2022
405c976
Article reference
mla-alm Dec 17, 2022
a3c263f
Fix
mla-alm Dec 17, 2022
96b5e91
Fixes
mla-alm Dec 17, 2022
600b9d5
Comment out implementation specific tests in Xoshiro_AlgorithmBehaves…
mla-alm Dec 18, 2022
e5c4536
Fix
mla-alm Dec 18, 2022
8a7dbdf
Merge remote-tracking branch 'origin/main' into mla-alm/lemire
mla-alm Dec 18, 2022
2dd1a78
Reenable sufficient checks for Xoshiro_AlgorithmBehavesAsExpected
mla-alm Dec 21, 2022
1b3c19b
Merge remote-tracking branch 'origin/main' into mla-alm/lemire
mla-alm Dec 21, 2022
f2a11d0
Fix
mla-alm Dec 21, 2022
a68e011
Add third party notice
mla-alm Dec 22, 2022
4ae4914
Resolve comments
mla-alm Dec 23, 2022
a4a6f93
Resolve comments
mla-alm Dec 23, 2022
e380d47
Resolve comments
mla-alm Dec 23, 2022
f50eabc
Merge remote-tracking branch 'origin/main' into mla-alm/lemire
mla-alm Dec 24, 2022
c739482
Merge branch 'main' into mla-alm/lemire
jeffhandley Jan 26, 2023
1bec03e
Resolve comments
mla-alm Jan 28, 2023
6d7b1f0
Merge branch 'dotnet:main' into mla-alm/lemire
mla-alm Jan 28, 2023
0cc3ecd
Refactor implementation to separate class
mla-alm Jan 28, 2023
20364ec
Merge remote-tracking branch 'origin/mla-alm/lemire' into mla-alm/lemire
mla-alm Jan 28, 2023
a22e745
Merge branch 'dotnet:main' into mla-alm/lemire
mla-alm Jan 29, 2023
9802461
Typo fix
mla-alm Jan 29, 2023
cc32925
Merge branch 'dotnet:main' into mla-alm/lemire
mla-alm Jan 30, 2023
89cb3bd
stephentoub's refactor
mla-alm Jan 30, 2023
4370688
Merge remote-tracking branch 'origin/mla-alm/lemire' into mla-alm/lemire
mla-alm Jan 30, 2023
ef38e9d
Reverting NextInt64 on Xoshiro128
mla-alm Feb 16, 2023
33654d2
Merge branch 'dotnet:main' into mla-alm/lemire
mla-alm Feb 16, 2023
95b4b42
Adjust test
mla-alm Feb 16, 2023
b28062c
Merge remote-tracking branch 'origin/mla-alm/lemire' into mla-alm/lemire
mla-alm Feb 16, 2023
6304f68
Merge branch 'dotnet:main' into mla-alm/lemire
mla-alm Feb 17, 2023
608a801
Update src/libraries/System.Private.CoreLib/src/System/Random.Xoshiro…
stephentoub Feb 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/libraries/System.Private.CoreLib/src/System/Random.Xoshiro…
…128StarStarImpl.cs
stephentoub authored Feb 17, 2023
commit 608a80158ed74b279d322f5d9c859d90ced4b871
Original file line number Diff line number Diff line change
@@ -117,7 +117,7 @@ public override long NextInt64()
}
}

// NextInt64 in Xoshiro128 has not been implemented with the Lemire algorithm like the related methods.
// NextInt64 in Xoshiro128 has not been implemented with the fastrange algorithm like the related methods.
// Benchmarking showed that on 32-bit changing implementation could cause regression.

public override long NextInt64(long maxValue)