Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Base64Decoder to ignore space chars, add IsValid methods and tests #79334

Closed
wants to merge 19 commits into from
Closed

Allow Base64Decoder to ignore space chars, add IsValid methods and tests #79334

wants to merge 19 commits into from

Commits on Dec 7, 2022

  1. Allow Base64Decoder to ignore space chars, add IsValid methods and tests 

    Chars now ignored:
9: Line feed
10: Horizontal tab
13: Carriage return
32: Space
-- Vertical tab omitted
    @heathbm
    heathbm committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6d72060 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Address PR feedback regarding Base64.IsValid

    @heathbm
    heathbm committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    35302b4 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Address PR feedback: General optimizations

    @heathbm
    heathbm committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    837b4bd View commit details
    Browse the repository at this point in the history

  2. Address PR feedback: Use vectorized decoding while enough src

    @heathbm
    heathbm committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9b3b581 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Address PR feedback: General optimization

    @heathbm
    heathbm committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9983889 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Address PR feedback: Optimize for whitespace (\r\n) every 76 bytes

    @heathbm
    heathbm committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f389289 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Address PR feedback: Implement driver/worker pattern with original code

    @heathbm
    heathbm committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    8482bbd View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. Address PR feedback: Reuse existing decoding method with whitespace

    @heathbm
    heathbm committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    dca7ee6 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Merge branch 'main' into add-base64-is-valid

    @heathbm
    heathbm committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    fe32cd3 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. Address PR feedback: Remove redundant empty buffer check

    @heathbm
    heathbm committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    261885c View commit details
    Browse the repository at this point in the history

  2. Address PR Feedback: Add missing magic constant comment

    @heathbm
    heathbm committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    fb9e8de View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Address PR Feedback: Avoid validation logic duplication

    @heathbm
    heathbm committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    b68d36c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-base64-is-valid

    @heathbm
    heathbm committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    689de25 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Throw Base64FormatException when whitespace should not be ignored 

    This fixes a failing test.
    @heathbm
    heathbm committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    745fd41 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Adress PR feedback: Improve naming of Base64Validator.cs internals

    @heathbm
    heathbm committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    b35ce12 View commit details
    Browse the repository at this point in the history

  2. Adress PR feedback: Add test to demonstrate extra whitespace is counted

    @heathbm
    heathbm committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5848058 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Address PR feedback: avoid bound-check

    @heathbm
    heathbm committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7c022b0 View commit details
    Browse the repository at this point in the history

  2. Address PR feedback: Base64.IsValid: Return when no more invalid chars

    @heathbm
    heathbm committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    04989b5 View commit details
    Browse the repository at this point in the history

  3. Address PR feedback: Refactor Bas64.IsValid method

    @heathbm
    heathbm committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5007df7 View commit details
    Browse the repository at this point in the history