Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single-stage-pipeline-with-resources.yml, use only pipeline-with-resources.yml #78968

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Nov 29, 2022

This reduces nesting of the pipeline templates. We hit an issue on the internal AzDO where the runtime.yml ran into this error:

The 'stages' parameter is not a valid StageList.
/eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml: Maximum events exceeded while evaluating the template. This may indicate an infinite loop or too many nested loops.

We found out that when we remove one level of nesting through the single-stage-pipeline-with-resources.yml the pipeline works again. This required re-indending a lot of the .yml files though, so I suggest reviewing the PR with whitespace changes ignored.

The interesting bit is that we don't hit this on the public AzDO instance, the current theory is that we have different AzDO templating limits applied there.

…th-resources.yml

This reduces nesting of the pipeline templates.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Nov 29, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This reduces nesting of the pipeline templates. We hit an issue on the internal AzDO where the runtime.yml ran into this error:

The 'stages' parameter is not a valid StageList.
/eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml: Maximum events exceeded while evaluating the template. This may indicate an infinite loop or too many nested loops.

We found out that when we remove one level of nesting through the single-stage-pipeline-with-resources.yml the pipeline works again. This required re-indending a lot of the .yml files though, so I suggest reviewing the PR with whitespace changes ignored.

The interesting bit is that we don't hit this on the public AzDO instance, the current theory is that we have different AzDO templating limits applied there.

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure

Milestone: -

@radical
Copy link
Member

radical commented Nov 29, 2022

Should eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml be removed now?

@akoeplinger
Copy link
Member Author

Should eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml be removed now?

Ah yes, thanks.

@akoeplinger
Copy link
Member Author

The failures are unrelated.

@akoeplinger akoeplinger merged commit af8a5ca into dotnet:main Nov 29, 2022
@akoeplinger akoeplinger deleted the pipeline-nesting branch November 29, 2022 23:26
@ghost ghost locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants