Exclude things which broken on Loongarch #78850

kant2002 · 2022-11-25T15:45:36Z

That's temporary stopgap to be able build on LA when have .NET 7.0.100 SDK
Plan to eventually unlock these features, but let's make build green for now.

This project fails on the Loongarch and not super nescessary for now. Unlock build

Hope that's all what's needed for dotnet#78749

ghost · 2022-11-25T15:45:46Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

That's temporary stopgap to be able build on LA when have .NET 7.0.100 SDK
Plan to eventually unlock these features, but let's make build green for now.

Author:	kant2002
Assignees:	-
Labels:	`area-Infrastructure-libraries`
Milestone:	-

Workaround for dotnet#78854 Basically feed built packages from `./build.sh packs` into test layout build process.

kant2002

One more exclusion for LA

kant2002 · 2022-12-03T03:35:01Z

@jkotas not sure if you are right person to ping regarding these changes.

jkotas · 2022-12-03T19:50:40Z

src/tests/Common/ilasm/ilasm.ilproj

@@ -5,5 +5,6 @@

  <PropertyGroup>
    <RuntimeIdentifier>$(OutputRid)</RuntimeIdentifier>
+    <NoWarn>$(NoWarn);NU1603</NoWarn>


Disabling this warning does not sound right

Test project want to use Microsoft.NETCore.App.Runtime.linux-loongarch64 version 7.0.0 which is not exists. Since I use locally built version it produces 8.0.0-dev and because I'm early in the cycle I "hope" that it's not important yet and while I make things working, I can remove this and use separate feed/folder with proper versions.

Test project which as for package - src/tests/Common/test_dependencies_fs/test_dependencies.fsproj

@kant2002 I think this shouldn't be necessary anymore since NetCoreAppToolCurrent which this project is targetting is set to net8.0 instead of net7.0 now.

Removed warning. Let's see how it worked out from main after this merges.

jkotas · 2022-12-03T19:54:32Z

src/tests/build.proj

@@ -9,6 +9,7 @@
    <MSBuildEnableAllPropertyFunctions>1</MSBuildEnableAllPropertyFunctions>
    <Language>C#</Language>
    <RuntimeIdentifier>$(OutputRid)</RuntimeIdentifier>
+    <RestoreAdditionalProjectSources Condition="$(TargetArchitecture) == 'loongarch64'">$(RestoreAdditionalProjectSources);$(ArtifactsPackagesDir)</RestoreAdditionalProjectSources>


This makes the build use packages that were just build instead of the one from the feed. Can we unify this with the mechanism that source build uses to achieve the same?

cc @MichaelSimons

Why is this needed? Which live built packages do you need to restore and reference here?

That's allow me to use Microsoft.NETCore.App.Runtime.linux-loongarch64
as described in #78854

I use this as temporary stopgap to be able to use test scripts for build tests and run them (to some degree)

This makes the build use packages that were just build instead of the one from the feed. Can we unify this with the mechanism that source build uses to achieve the same?

Source-build does not have a special mechanism to do this within a repo. The source-build mechanism is used to pickup packages that were built from a different repo within the source build.

Technically this line not needed, and only similar line in the file is here. But I assume concerns applied to line below.

@ViktorHofer isn't there some other way of forcing tests to use the live built packages?

@kant2002 I'm curious does the restore error only happen for the test_dependencies.fsproj you mentioned in #78854?

I do not actually know, since I do not fully understand how test infra setup. So I was worrying that I may break something further down the road. I can play according to your directions if you have some ideas to test

jkotas · 2022-12-03T19:58:26Z

@jkotas not sure if you are right person to ping regarding these changes.

The area owners are the best people to ping.

kant2002

Test project want to use Microsoft.NETCore.App.Runtime.linux-loongarch64 version 7.0.0 which is not existsing. Since I use locally built version it produces 8.0.0-dev and because I'm early in the cycle I "hope" that it's not important yet.

src/tests/Common/test_dependencies_fs/test_dependencies.fsproj

UPDATE this was commit message which I by mistake enter in VS Code Online

…h64 version 7.0.0 which is not existsing. Since I use locally built version it produces 8.0.0-dev and because I'm early in the cycle I "hope" that it's not important yet. src/tests/Common/test_dependencies_fs/test_dependencies.fsproj

ghost · 2023-01-09T17:00:10Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

That's temporary stopgap to be able build on LA when have .NET 7.0.100 SDK
Plan to eventually unlock these features, but let's make build green for now.

Author:	kant2002
Assignees:	-
Labels:	`area-Infrastructure`, `community-contribution`
Milestone:	-

eng/Subsets.props

src/libraries/Directory.Build.props

agocke · 2023-04-10T20:08:45Z

I'd expect that special-casing for loongarch and freebsd would be pretty similar (we don't publish packages for either) but it doesn't look quite the same. Any reason for that?

kant2002 · 2023-04-10T20:13:42Z

Is it possible that CrossGen2 on FreeBSD magically works because ABI same as on Nix? Or maybe same situation as with me and LA64, nobody run whole build using dotnet infra? Other option is that some GC hole(there at least one) lead to Crossgen2 getting in the loop and as such never finished.

Here my guesses

agocke · 2023-04-17T18:23:05Z

eng/Subsets.props

@@ -320,7 +321,7 @@
                             $(CoreClrProjectRoot)tools\dotnet-pgo\dotnet-pgo.csproj;
                             $(CoreClrProjectRoot)tools\aot\ILCompiler\repro\repro.csproj;
                             $(CoreClrProjectRoot)tools\r2rtest\R2RTest.csproj" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true'"/>
-    <ProjectToBuild Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2.csproj" Category="clr" />
+    <ProjectToBuild Condition="'$(Crossgen2Supported)' == 'true'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2.csproj" Category="clr" />


This doesn't look right to me. Crossgen2 should build just fine. It may not run properly, but if we can't build it I think something else is going on.

#84781 disabled running crossgen2 for riscv. It should be done in the same place.

After some thinking I'm not so sure that this would be enough to just make changes in src/coreclr/crossgen-corelib.proj. Don't know what Risk-V guys did, but in my case I was able to build whole runtime + almost run all tests using standards method.

Will try to resurrect work. When I file issue, it was very ideal, since I have LA64 .NET 7 SDK and now it would require some jumping from the hoops on my side 😢

huoyaoyuan · 2023-04-20T06:47:40Z

/cc @shushanhf Have you looked into this?

shushanhf · 2023-04-20T07:18:08Z

/cc @shushanhf Have you looked into this?

Thanks for your reminding.
I didn't see the lastest talking.

@agocke @jkotas @am11

As @kant2002 said, it is very necessary to adding the LA64's testing env although there is still some work to do.
I will focus on the LoongArch64's developping through the rest of the year.

First, I have started to push some PRs to solve the failed tests within CoreRoot. #69705

Second, for testing the LA64, can we implement it in several steps ?
(1) we can just supporting the building LoongArch64 to avoid the simple building errors;
(2) creating an issue to tracking and solving the resting problems.
If needed, we can supply some LoongArch64 machines.

am11 · 2023-04-20T07:23:06Z

Does #85038 supersede this PR?

shushanhf · 2023-04-20T07:31:18Z

Does #85038 supersede this PR?

Only this PR is not enough.
Today I will push anthother PR related this.

If all the testing cases passed, I think there is still some other problems.

jkotas · 2023-04-20T12:44:46Z

we can just supporting the building LoongArch64 to avoid the simple building errors

If you meant adding a LoongArch64 build to the CI, we would need a docker image with Linux x64 hosted cross-build environment created in https://github.com/dotnet/dotnet-buildtools-prereqs-docker repo for that. Depends on #63075 .

agocke · 2023-04-20T18:02:38Z

eng/Subsets.props

@@ -365,7 +366,7 @@
      Test="true" Category="tools"/>
  </ItemGroup>

-  <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
+  <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+')) and '$(Crossgen2Supported)' == 'true'">


This seems obsolete with the crossgen-corelib change

shushanhf · 2023-05-18T06:32:09Z

Hi, @kant2002
The #85038 had been merged.
And we have built the hello-world by SDK8.0-Preview4 on LA64 #69705 (comment)

Next we will improve the reliability for LA64.
The crossgen2 maybe is ok for simple tests for LA64.

kant2002 · 2023-05-19T03:02:15Z

@shushanhf where can I get SDK8.0-Preview4 for LA ? I prefer to test whole build process if possible.

shushanhf · 2023-05-19T03:16:09Z

@shushanhf where can I get SDK8.0-Preview4 for LA ? I prefer to test whole build process if possible.

LA's SDK8.0-preview4 can only build liking hello-world or lager FlightFinder, if building the whole runtime maybe have to wait some time.
Now we are improving the reliability for LA64. I will give you a more stable version later.

agocke · 2023-07-17T20:07:02Z

@kant2002 is this still relevant? Or should we close it out?

ghost · 2023-07-31T21:02:05Z

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost · 2023-08-15T00:01:36Z

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

kant2002 added 2 commits November 25, 2022 23:40

Ignore JSImportGenerator

a22df01

This project fails on the Loongarch and not super nescessary for now. Unlock build

Disable building Crossgen2

2763ce1

Hope that's all what's needed for dotnet#78749

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Nov 25, 2022

ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 25, 2022

build-analysis bot mentioned this pull request Nov 25, 2022

CI build failure: Build MacCatalyst x64 Release AllSubsets_Mono - XcodeBuildApp task failed unexpectedly - Could not find System.Runtime.Tests.app #78778

Closed

Unlock building test layout

1fd832f

Workaround for dotnet#78854 Basically feed built packages from `./build.sh packs` into test layout build process.

This was referenced Nov 30, 2022

Tracking issue for CI build timeouts #76454

Closed

Error MSB3073: dotnet restore failing in CI on FreeBSD #78251

Open

Add custom restore source only for LA64 arch

186ef52

kant2002 commented Dec 2, 2022

View reviewed changes

Hmm, sometimes I do wierd mistakes

c0aec51

jkotas reviewed Dec 3, 2022

View reviewed changes

kant2002 commented Dec 5, 2022

View reviewed changes

ViktorHofer added area-Infrastructure and removed area-Infrastructure-libraries labels Jan 9, 2023

akoeplinger reviewed Jan 11, 2023

View reviewed changes

eng/Subsets.props Outdated Show resolved Hide resolved

kant2002 added 2 commits February 20, 2023 10:50

Apply PR feedback

7739236

Merge branch 'main' into kant/exclude-loongarch-not-implemented

830c779

jkotas reviewed Feb 20, 2023

View reviewed changes

src/libraries/Directory.Build.props Outdated Show resolved Hide resolved

kant2002 added 2 commits February 20, 2023 12:21

Move exclusion to tests.proj

3ac0716

Removed warning. Let's see how it worked out from main after this merges

874b12f

build-analysis bot mentioned this pull request Feb 26, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

agocke reviewed Apr 17, 2023

View reviewed changes

kant2002 added 2 commits April 18, 2023 08:48

Merge branch 'main' into kant/exclude-loongarch-not-implemented

94d0e44

Use same method for disabling crossgen as Risk-V

76cad70

build-analysis bot mentioned this pull request Apr 18, 2023

nativeaot/SmokeTests/DwarfDump failing on linux-x64 Debug #84979

Closed

agocke reviewed Apr 20, 2023

View reviewed changes

danmoseley added the arch-loongarch64 label May 31, 2023

agocke added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 17, 2023

ghost added the no-recent-activity label Jul 31, 2023

ghost closed this Aug 15, 2023

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

This pull request was closed.

Exclude things which broken on Loongarch #78850

Exclude things which broken on Loongarch #78850

Conversation

kant2002 commented Nov 25, 2022

ghost commented Nov 25, 2022

kant2002 left a comment

Choose a reason for hiding this comment

kant2002 commented Dec 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkotas commented Dec 3, 2022

kant2002 left a comment • edited Loading

Choose a reason for hiding this comment

ghost commented Jan 9, 2023

agocke commented Apr 10, 2023

kant2002 commented Apr 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huoyaoyuan commented Apr 20, 2023

shushanhf commented Apr 20, 2023 • edited Loading

am11 commented Apr 20, 2023

shushanhf commented Apr 20, 2023

jkotas commented Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

shushanhf commented May 18, 2023

kant2002 commented May 19, 2023

shushanhf commented May 19, 2023

agocke commented Jul 17, 2023

ghost commented Jul 31, 2023

ghost commented Aug 15, 2023

kant2002 left a comment •

edited

Loading

shushanhf commented Apr 20, 2023 •

edited

Loading

jkotas commented Apr 20, 2023 •

edited

Loading