-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable distributed transactions test #78468
Conversation
Tagging subscribers to this area: @roji Issue DetailsSee #77241 (comment)
|
811f544
to
6a3157e
Compare
@@ -529,6 +529,7 @@ public void ImplicitDistributedTransactions_cannot_be_changed_after_being_set() | |||
} | |||
|
|||
[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))] | |||
[ActiveIssue("https://github.com/dotnet/runtime/issues/77241")] | |||
public void ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_false
right below this also be disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing a test failure for that in #77241, did I miss another failure somewhere?
I agree that the failure likely isn't specifically related to ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true, and part of the reason for disabling it is to see if the failure slips to another test, which may provide a bit more information... Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any failures for that one either so that sounds good to me.
See #77241 (comment)