Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the stable 7.0.100 SDK #78034

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Update to the stable 7.0.100 SDK #78034

merged 2 commits into from
Nov 30, 2022

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 8, 2022

No description provided.

@ViktorHofer ViktorHofer added this to the 8.0.0 milestone Nov 8, 2022
@ViktorHofer ViktorHofer self-assigned this Nov 8, 2022
@agocke
Copy link
Member

agocke commented Nov 16, 2022

Thanks for getting this started -- I think we should also eventually do this for the 7.0 branch.

@kasperk81
Copy link
Contributor

@ViktorHofer is this blocked on something?

@marek-safar
Copy link
Contributor

@vzarytovskii is the error resource ILLink.Substitutions.xml in FSharp.Core, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(3,6): error IL2040: FSharp.Core: Could not find embedded resource 'FSharpOptimizationCompressedData.FSharp.Core' to remove in assembly 'FSharp.Core'. [/__w/1/s/src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj::TargetFramework=net7.0] know issue ?

@ViktorHofer
Copy link
Member Author

@ViktorHofer is this blocked on something?

Not blocked on anything. We just need to spend some time to understand the build and test failures. Thanks @marek-safar for starting with that.

@vzarytovskii
Copy link
Member

@vzarytovskii is the error resource ILLink.Substitutions.xml in FSharp.Core, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(3,6): error IL2040: FSharp.Core: Could not find embedded resource 'FSharpOptimizationCompressedData.FSharp.Core' to remove in assembly 'FSharp.Core'. [/__w/1/s/src/libraries/System.Formats.Cbor/tests/System.Formats.Cbor.Tests.csproj::TargetFramework=net7.0] know issue ?

Those resources may or may not be there, depending on which compiler version is used (newer versions are compressing resource, older do not).
When it was added (by @teo-tsirpanis), we assumed that linker will just ignore it if it's missing.

@teo-tsirpanis
Copy link
Contributor

The error is actually a warning so we can suppress it.

@marek-safar
Copy link
Contributor

I don't think we want to suppress this warning for whole runtime repo and updating each affected project manually is not a great experience either.

@vzarytovskii
Copy link
Member

I don't think we want to suppress this warning for whole runtime repo and updating each affected project manually is not a great experience either.

I have disabled trimming all resorces for FSharp.Core - dotnet/fsharp#14395
It will take time to insert, propagate and release though.

@kasperk81
Copy link
Contributor

Could not find embedded resource 'FSharpOptimizationCompressedData.FSharp.Core'

false alarm: f# package has never included this resource. runtime has no control over that package. usage is same as before. so it should not raise to "error" level

for whole runtime repo

there are five fsproj files in this repo and only one of them is trimmed: cbor test project. suppressing the warning in one file or removing cbor test project from trimming test should be alright for sdk update (esp when the error's severity itself is in question)

@ViktorHofer ViktorHofer reopened this Nov 29, 2022
@akoeplinger akoeplinger changed the title Update to the stable 7.0.100 SDK (WIP) Update to the stable 7.0.100 SDK Nov 30, 2022
@akoeplinger akoeplinger marked this pull request as ready for review November 30, 2022 10:53
@akoeplinger
Copy link
Member

Suppressing the linker warning about the missing F# resource was indeed just necessary in one project so I went with that. We can remove it once the F# fix propagates.

The MacCatalyst failure is unrelated.

@akoeplinger akoeplinger merged commit b3afffa into main Nov 30, 2022
@akoeplinger akoeplinger deleted the ViktorHofer-patch-1 branch November 30, 2022 11:52
@akoeplinger
Copy link
Member

Thanks for getting this started -- I think we should also eventually do this for the 7.0 branch.

@agocke release/7.0 is already using the stable 7.0.100 SDK, it was bumped as part of #78107. For some reason we didn't hit the F# linker issue there though.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants