Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lvaEnregMultiRegVars and lvaEnregEHVars when switching to MinOpts #77502

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

SingleAccretion
Copy link
Contributor

Should fix stress failures introduced by #76263.

Side note: not sure how much value does lvaEnregMultiRegVars offer - I've never used it personally, has anyone else?

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 26, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 26, 2022
@ghost
Copy link

ghost commented Oct 26, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Should fix stress failures introduced by #76263.

Side note: not sure how much value does lvaEnregMultiRegVars offer - I've never used it personally, has anyone else?

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Oct 26, 2022

heh, I think I've hit this issue in my OptLevel PR 🙂

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Oct 26, 2022

@dotnet/jit-contrib

Edit: formatting failures have been fixed by #77511.

@AndyAyersMS AndyAyersMS merged commit 65233eb into dotnet:main Oct 27, 2022
@SingleAccretion SingleAccretion deleted the Fix-Enreg-Check branch October 27, 2022 13:55
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants