Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [DebuggerStepThrough] to MulticastDelegate constructors. #77132

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

chuckries
Copy link
Contributor

Adding [DebuggerStepThrough] to these constructors allows debuggers to avoid stepping into them and stopping regardless of Just My Code settings. This is desirable for debuggers as there is little benefit to stopping in these constructors as they are primarily infrastructure inserted by the compiler.

Adding [DebuggerStepThrough] to these constructors allows debuggers to
avoid stepping into them and stopping regardless of Just My Code
settings. This is desirable for debuggers as there is little benefit to
stopping in these constructors as they are primarily infrastructure
inserted by the compiler.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 17, 2022
@chuckries
Copy link
Contributor Author

fixes #77131

@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Adding [DebuggerStepThrough] to these constructors allows debuggers to avoid stepping into them and stopping regardless of Just My Code settings. This is desirable for debuggers as there is little benefit to stopping in these constructors as they are primarily infrastructure inserted by the compiler.

Author: chuckries
Assignees: -
Labels:

area-Diagnostics-coreclr, community-contribution

Milestone: -

@tommcdon
Copy link
Member

LGTM - adding @noahfalk @hoyosjs for additional review

@tommcdon
Copy link
Member

Adding @thaystg @lambdageek for awareness and in case something similar should be done for mono

Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a few other folks for additional review.

@hoyosjs
Copy link
Member

hoyosjs commented Oct 20, 2022

All issues are known (cc: @missymessa @AlitzelMendez @ulisesh @markwilkie, since the check tab is still red...), so merging this one.

@hoyosjs hoyosjs merged commit 6e51009 into dotnet:main Oct 20, 2022
@ulisesh
Copy link
Contributor

ulisesh commented Oct 20, 2022

Thanks for the heads up @hoyosjs, the check is red by design. We are still deciding if we want to make the check green if all failures are known. Something interesting about the generated check is that the failures are shown as infrastructure failures but they look like test issues to me. I'll investigate what happened

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants