-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [DebuggerStepThrough] to MulticastDelegate constructors. #77132
Add [DebuggerStepThrough] to MulticastDelegate constructors. #77132
Conversation
Adding [DebuggerStepThrough] to these constructors allows debuggers to avoid stepping into them and stopping regardless of Just My Code settings. This is desirable for debuggers as there is little benefit to stopping in these constructors as they are primarily infrastructure inserted by the compiler.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
fixes #77131 |
Tagging subscribers to this area: @tommcdon Issue DetailsAdding [DebuggerStepThrough] to these constructors allows debuggers to avoid stepping into them and stopping regardless of Just My Code settings. This is desirable for debuggers as there is little benefit to stopping in these constructors as they are primarily infrastructure inserted by the compiler.
|
Adding @thaystg @lambdageek for awareness and in case something similar should be done for mono |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've added a few other folks for additional review.
All issues are known (cc: @missymessa @AlitzelMendez @ulisesh @markwilkie, since the check tab is still red...), so merging this one. |
Thanks for the heads up @hoyosjs, the check is red by design. We are still deciding if we want to make the check green if all failures are known. Something interesting about the generated check is that the failures are shown as infrastructure failures but they look like test issues to me. I'll investigate what happened |
Adding [DebuggerStepThrough] to these constructors allows debuggers to avoid stepping into them and stopping regardless of Just My Code settings. This is desirable for debuggers as there is little benefit to stopping in these constructors as they are primarily infrastructure inserted by the compiler.