Adding the Vector512 and Vector512<T> types #76642

tannergooding · 2022-10-04T22:41:10Z

This resolves #73262
This resolves #75791

dotnet-issue-labeler · 2022-10-04T22:41:18Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-issue-labeler · 2022-10-04T22:41:19Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

ghost · 2022-10-04T22:42:25Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details

Marking this as draft since we need to add corresponding tests to https://github.com/dotnet/runtime/tree/main/src/tests/JIT/HardwareIntrinsics/General, but it is pending #74886 to avoid conflicts.

Author:	tannergooding
Assignees:	tannergooding
Labels:	`area-System.Runtime.Intrinsics`, `new-api-needs-documentation`
Milestone:	-

src/coreclr/vm/fieldmarshaler.h

src/coreclr/tools/Common/Compiler/VectorFieldLayoutAlgorithm.cs

vargaz · 2022-10-26T16:26:27Z

The mono changes look ok. Not sure that mono can properly align this type to 64 bytes.

tannergooding · 2022-10-26T16:58:07Z

Not sure that mono can properly align this type to 64 bytes.

Mono has a different tracking issue covering its need to properly pad all of the Vector types. Noting that padding and alignment are two different things here. RyuJIT correctly "pads" these types (e.g. if you have int x; Vector512<int> y;, y is at offset 64). It does not guarantee correct alignment for GC tracked data (e.g. Vector512<int>[] will not be 64-byte aligned in memory) but will attempt to correctly align stack locals (e.g. Vector512<int> local; should generally be aligned within a given method's stack).

dakersnar

Looks good to me. I only skimmed the tests, but they look comprehensive, and I'm assuming you have full coverage.

Added a few clarifying comments but overall approving this.

src/coreclr/tools/Common/Compiler/VectorFieldLayoutAlgorithm.cs

src/coreclr/vm/methodtablebuilder.cpp

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256.cs

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512_1.cs

…or Arm64

stephentoub · 2022-11-03T14:22:26Z

@tannergooding, is this mergable now? Thanks.

tannergooding · 2022-11-03T14:48:22Z

@stephentoub, was asked to wait until at least end of the week by @davidwrighton so #74886 could go in first. Marked this "blocked" for now.

stephentoub · 2022-11-03T14:49:29Z

Got it, thanks.

dakersnar

Reviewing the newest commits. Are all of the newly exposed methods unit tested already?

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs

tannergooding · 2023-01-10T22:39:43Z

@fanyang-mono, I've logged #80467 and disabled the tests under <ItemGroup Condition="'$(RuntimeFlavor)' == 'mono' and '$(RuntimeVariant)' == 'llvmfullaot' ">

…here appropriate

tannergooding · 2023-01-11T23:05:06Z

Arm64 CI timeouts appear to be a broader issue atm, but I'd still like to get llvmfullaot passing at least once since it hadn't been passing previously.

Feedback has been addressed and new review was given by other R2R/Crossgen owners

radekdoulik · 2023-01-26T09:35:21Z

src/mono/mono/mini/simd-intrinsics.c

-					} else if ((fsig->params [0]->type == MONO_TYPE_GENERICINST) && (fsig->params [1]->type == MONO_TYPE_GENERICINST)) {
-						instc0 = OP_FDIV;
-						break;


I am curious, why was this and similar branch in the multiply case removed? It is disabling SIMD code generation for Vector128 div/mul ops for wasm and probably more on the other platforms too. It would help me to find out how to fix it.

@lewing is meanwhile trying to re-enable it in this draft #81201 to see if CI would complain.

This looks like a merge mistake to me. The correct version should be #78784.

It looks like it was a bad merge into this PR. The correct code is in 8158cb8be51 (from #78784) but then when the PR was merged an incomplete version from this PR was picked instead during the merge (67abfd0)

Sorry for that. I don't remember a merge conflict coming up, so I'd guess this was automatically done on git's end.

Cool, thanks for looking into that and confirming it.

fanyang-mono · 2023-01-26T15:30:41Z

src/mono/mono/mini/simd-intrinsics.c

@@ -339,9 +336,6 @@ emit_simd_ins_for_binary_op (MonoCompile *cfg, MonoClass *klass, MonoMethodSigna
 						ins = emit_simd_ins (cfg, klass, OP_XBINOP_BYSCALAR, ins->dreg, args [1]->dreg);
 						ins->inst_c0 = OP_FMUL;
 						return ins;
-					} else if ((fsig->params [0]->type == MONO_TYPE_GENERICINST) && (fsig->params [1]->type == MONO_TYPE_GENERICINST)) {


tannergooding added 2 commits October 4, 2022 14:33

Adding the Vector512 and Vector512<T> types

eaa08e0

Support properly packing Vector512<T>

03dd856

dotnet-issue-labeler bot added the new-api-needs-documentation label Oct 4, 2022

ghost assigned tannergooding Oct 4, 2022

tannergooding added the area-System.Runtime.Intrinsics label Oct 4, 2022

AaronRobinsonMSFT reviewed Oct 5, 2022

View reviewed changes

src/coreclr/vm/fieldmarshaler.h Show resolved Hide resolved

src/coreclr/tools/Common/Compiler/VectorFieldLayoutAlgorithm.cs Outdated Show resolved Hide resolved

Merge remote-tracking branch 'dotnet/main' into vector512

8d7791e

tannergooding marked this pull request as ready for review October 26, 2022 16:14

tannergooding requested review from vargaz, lambdageek, SamMonoRT and MichalStrehovsky as code owners October 26, 2022 16:14

dakersnar approved these changes Oct 28, 2022

View reviewed changes

Responding to PR feedback and ensure Vector512 is treated as an HFA f…

3a80f29

…or Arm64

dakersnar approved these changes Oct 28, 2022

View reviewed changes

Merge remote-tracking branch 'dotnet/main' into vector512

0157044

build-analysis bot mentioned this pull request Oct 31, 2022

Tracking issue for CI build timeouts #76454

Closed

tannergooding added the blocked Issue/PR is blocked on something - see comments label Nov 3, 2022

tannergooding added 2 commits November 4, 2022 08:46

Merge remote-tracking branch 'dotnet/main' into vector512

012084a

Bring Vector512 inline with the new Vector64/128/256 APIs

13dc1df

dakersnar approved these changes Nov 4, 2022

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs Show resolved Hide resolved

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs Show resolved Hide resolved

Merge remote-tracking branch 'dotnet/main' into vector512

7d23e27

tannergooding added 2 commits January 9, 2023 17:24

Remove a stray .

3457948

Fixing the NativeAOT field layout tests

1b0adc0

tannergooding force-pushed the vector512 branch from eca737d to 1b0adc0 Compare January 10, 2023 07:32

build-analysis bot mentioned this pull request Jan 10, 2023

Tracking issue for CI build failure "Installing openssl@3 has failed!" #80428

Closed

Update an addition location where the R2R version is defined

6be8dec

tannergooding force-pushed the vector512 branch from a72c71f to 6be8dec Compare January 10, 2023 16:54

tannergooding added 2 commits January 10, 2023 10:01

Merge remote-tracking branch 'dotnet/main' into vector512

8f001fa

Disable Vector512 tests for llvmfullaot due to dotnet#80467

2527bcd

fanyang-mono and others added 3 commits January 10, 2023 22:22

Increase the value of ngsharedvt-trampolines

d1fc03d

Move various HWIntrinsics to outerloop for unaccelerated platforms

399e4c5

Ensure the HardwareIntrinsics tests are being filtered to outerloop w…

9bb141c

…here appropriate

Merge branch 'dotnet:main' into vector512

6b049e1

tannergooding merged commit 00596e5 into dotnet:main Jan 12, 2023

tannergooding deleted the vector512 branch January 12, 2023 16:33

AndyAyersMS mentioned this pull request Jan 25, 2023

Test failure JIT\\opt\\ObjectStackAllocation\\ObjectStackAllocationTests\\ObjectStackAllocationTests.cmd #81103

Closed

radekdoulik reviewed Jan 26, 2023

View reviewed changes

fanyang-mono reviewed Jan 26, 2023

View reviewed changes

lambdageek mentioned this pull request Jan 26, 2023

[mono] Fix missing simd mul/div case #81201

Merged

This was referenced Jan 29, 2023

[Perf] Linux/x64: 92 Regressions on 1/14/2023 12:48:25 AM dotnet/perf-autofiling-issues#11779

Closed

[Perf] Linux/x64: 77 Regressions on 1/12/2023 10:41:19 PM dotnet/perf-autofiling-issues#11805

Closed

JulieLeeMSFT mentioned this pull request Feb 8, 2023

What's new in .NET 8 Preview 1 dotnet/core#8133

Closed

3 tasks

ghost locked as resolved and limited conversation to collaborators Feb 25, 2023

jeffhandley added the blog-candidate Completed PRs that are candidate topics for blog post coverage label Mar 14, 2023

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Oct 18, 2023

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 18, 2023

ericstj removed breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Oct 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding the Vector512 and Vector512<T> types #76642

Adding the Vector512 and Vector512<T> types #76642

tannergooding commented Oct 4, 2022 •

edited

Loading

dotnet-issue-labeler bot commented Oct 4, 2022

dotnet-issue-labeler bot commented Oct 4, 2022

ghost commented Oct 4, 2022

vargaz commented Oct 26, 2022

tannergooding commented Oct 26, 2022

dakersnar left a comment

stephentoub commented Nov 3, 2022

tannergooding commented Nov 3, 2022

stephentoub commented Nov 3, 2022

dakersnar left a comment

tannergooding commented Jan 10, 2023

tannergooding commented Jan 11, 2023

radekdoulik Jan 26, 2023

fanyang-mono Jan 26, 2023

lambdageek Jan 26, 2023

tannergooding Jan 26, 2023

radekdoulik Jan 26, 2023

fanyang-mono Jan 26, 2023

Adding the Vector512 and Vector512<T> types #76642

Adding the Vector512 and Vector512<T> types #76642

Conversation

tannergooding commented Oct 4, 2022 • edited Loading

dotnet-issue-labeler bot commented Oct 4, 2022

dotnet-issue-labeler bot commented Oct 4, 2022

ghost commented Oct 4, 2022

vargaz commented Oct 26, 2022

tannergooding commented Oct 26, 2022

dakersnar left a comment

Choose a reason for hiding this comment

stephentoub commented Nov 3, 2022

tannergooding commented Nov 3, 2022

stephentoub commented Nov 3, 2022

dakersnar left a comment

Choose a reason for hiding this comment

tannergooding commented Jan 10, 2023

tannergooding commented Jan 11, 2023

radekdoulik Jan 26, 2023

Choose a reason for hiding this comment

fanyang-mono Jan 26, 2023

Choose a reason for hiding this comment

lambdageek Jan 26, 2023

Choose a reason for hiding this comment

tannergooding Jan 26, 2023

Choose a reason for hiding this comment

radekdoulik Jan 26, 2023

Choose a reason for hiding this comment

fanyang-mono Jan 26, 2023

Choose a reason for hiding this comment

tannergooding commented Oct 4, 2022 •

edited

Loading