Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hot_reload] Add instance fields #76462

Merged
merged 55 commits into from
Nov 22, 2022
Merged

[hot_reload] Add instance fields #76462

merged 55 commits into from
Nov 22, 2022

Commits on Nov 15, 2022

  1. [hot_reload] Add new AddInstanceField test

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    74ac7d4 View commit details
    Browse the repository at this point in the history

  2. WIP builds doesn't link; need impl for mono_metadata_update_ldflda

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0841c40 View commit details
    Browse the repository at this point in the history

  3. WIP builds

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    f244218 View commit details
    Browse the repository at this point in the history

  4. WIP test runs, fails on string load/stores

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b13e6ff View commit details
    Browse the repository at this point in the history

  5. Simple test works

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a404ee3 View commit details
    Browse the repository at this point in the history

  6. Add AddInstanceFieldToExistingType capability to runtime

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c40cb12 View commit details
    Browse the repository at this point in the history

  7. fix comment; remove unused var

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0c7ab0b View commit details
    Browse the repository at this point in the history

  8. Add instance field: reflection and nested struct

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ceaee7c View commit details
    Browse the repository at this point in the history

  9. make TypedReference work with added fields

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d9d8827 View commit details
    Browse the repository at this point in the history

  10. Add FieldInfo.SetValue testcase

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cfc91d3 View commit details
    Browse the repository at this point in the history

  11. make FieldInfo.SetValue work

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d423ae8 View commit details
    Browse the repository at this point in the history

  12. fix whitespace

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    95318ff View commit details
    Browse the repository at this point in the history

  13. more whitespace

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b05d541 View commit details
    Browse the repository at this point in the history

  14. remove TODO

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    afdaabf View commit details
    Browse the repository at this point in the history

  15. fix Windows build error

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    9582cb3 View commit details
    Browse the repository at this point in the history

  16. review feedback

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    042b431 View commit details
    Browse the repository at this point in the history

  17. Implement LDFLDA opcode for added fields; add test

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a5a8815 View commit details
    Browse the repository at this point in the history

  18. fix build

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    afe37d6 View commit details
    Browse the repository at this point in the history

  19. rm TODO

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    17a9927 View commit details
    Browse the repository at this point in the history

  20. Disable test on CoreCLR

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    62ab2e6 View commit details
    Browse the repository at this point in the history

  21. WIP start adding a wasm debugger test

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    69de824 View commit details
    Browse the repository at this point in the history

  22. WIP XXX - semi-broken debugger test

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2c7b8e7 View commit details
    Browse the repository at this point in the history

  23. OK - test is failing in the debugger agent (see details) 

    * Assertion at
/Users/alklig/work/dotnet-runtime/runtime/src/mono/mono/component/debugger-agent.c:9829,
condition `!m_field_is_from_update (f)' not met
    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    dadda4e View commit details
    Browse the repository at this point in the history

  24. make the debugger test a bit more interesting

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b9b0c6b View commit details
    Browse the repository at this point in the history

  25. implement a debugger test that gets/sets instance fields

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    18f440f View commit details
    Browse the repository at this point in the history

  26. Clear the debugger type cache on EnC update 

    we only need to clear the type on which fields or methods were
added. but right now we just clear the whole cache
    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ef7805d View commit details
    Browse the repository at this point in the history

  27. [sdb] implement get/set field for added instance fields

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    79f5abc View commit details
    Browse the repository at this point in the history

  28. [handles] remove the field getter/setter macros 

    They had no callers, and now we don't do things this way - we assume
the enclosing object had been pinned by a stack reference.
    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    13a4b25 View commit details
    Browse the repository at this point in the history

  29. [metadata-update] comments on asserts

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    88a466a View commit details
    Browse the repository at this point in the history

  30. implement mono_field_get_addr added field support

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    4d7ee0b View commit details
    Browse the repository at this point in the history

  31. add TODO for initializers for added literals

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    67e02a0 View commit details
    Browse the repository at this point in the history

  32. remove last use of MONO_HANDLE_SET_FIELD_REF

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    8d1a90e View commit details
    Browse the repository at this point in the history

  33. WeakAttribute is not picked up from added fields

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2a01071 View commit details
    Browse the repository at this point in the history

  34. Add a test for an array with RVA

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    8fabc0d View commit details
    Browse the repository at this point in the history

  35. Impl mono_metadata_field_info_full

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ca9c3c9 View commit details
    Browse the repository at this point in the history

  36. mono_class_get_field_token

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    49a907e View commit details
    Browse the repository at this point in the history

  37. mono_field_get_rva

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    54f4f2a View commit details
    Browse the repository at this point in the history

  38. Add SetValueDirect/GetValueDirect test (failing)

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    78eeee2 View commit details
    Browse the repository at this point in the history

  39. Implement GetValueDirect - hot reload test passes now

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    afe88ec View commit details
    Browse the repository at this point in the history

  40. fix init

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6e9811d View commit details
    Browse the repository at this point in the history

  41. Added test for auto property; crashes in ves_icall_RuntimePropertyInf… 

    …o_get_property_info
    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d90d17c View commit details
    Browse the repository at this point in the history

  42. fix rebase whitespace

    @lambdageek
    lambdageek committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    517978e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. WIP checkpoint add_props 

    Note: we're not doing anything with the new PropertyMap row

Note2: we get MethodSemantics rows for properties that got updated,
and we're currently ignoring them.  Need to check that this is
reasonable. (A test would be to use reflection to grab a getter or
setter whose method body was changed and then try and invoke it and
verify that we're calling the correct method.)
    @lambdageek
    lambdageek committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    619d956 View commit details
    Browse the repository at this point in the history

  2. fixup comment - repeated MethodSemantics rows can happen

    @lambdageek
    lambdageek committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9b6503a View commit details
    Browse the repository at this point in the history

  3. added properties iteration

    @lambdageek
    lambdageek committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    21dad8b View commit details
    Browse the repository at this point in the history

  4. protect callers of mono_class_get_property_token

    @lambdageek
    lambdageek committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    2bc5e5a View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. fix build warnings

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ac34462 View commit details
    Browse the repository at this point in the history

  2. fix dynamic component builds

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    fbcd1b2 View commit details
    Browse the repository at this point in the history

  3. make mono_class_get_property_token work for added props

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2934993 View commit details
    Browse the repository at this point in the history

  4. add test for adding instance event

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    9c4c18a View commit details
    Browse the repository at this point in the history

  5. basic event reflection works

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3216155 View commit details
    Browse the repository at this point in the history

  6. Fire the new event, too

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    a6dadc1 View commit details
    Browse the repository at this point in the history

  7. make reflection MetadataToken work

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    bd571f9 View commit details
    Browse the repository at this point in the history

  8. fix dynamic component build

    @lambdageek
    lambdageek committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    b14f565 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. remove unused ifdefs and fix whitespace

    @lambdageek
    lambdageek committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0a849ac View commit details
    Browse the repository at this point in the history