-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generated runtime.json when building shared framework packages. #76068
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsWith this change, when I build:
The new rid shows up in the packages:
@ericstj @ViktorHofer ptal.
|
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
@@ -223,6 +223,8 @@ | |||
ResolveLibrariesRuntimeFilesFromLocalBuild" /> | |||
|
|||
<PropertyGroup> | |||
<BundledRuntimeIdentifierGraphFile>$(RuntimeIdGraphDefinitionFile)</BundledRuntimeIdentifierGraphFile> | |||
<!-- Keep in sync with outputs defined in Microsoft.NETCore.Platforms.csproj. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be in the .targets
file otherwise Microsoft.NET.Sdk
overwrites it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good now. We just need to make sure that the package is correctly produced in the all configurations leg. Can you verify that offline as we don't upload packages in PRs afaik because of size constraints.
You would first do a build.sh libs
and check that Microsoft.NetCore.Platforms package doesn't get produced but that the library is built and then do a build.sh libs -allconfigurations
and check that the Microsoft.NetCore.Platforms package exists under artifacts/packages/...
EDIT: Doing this kind of validation myself right now, just to be sure.
EDIT2: Works as expected. Nice!
My mistake. I mentioned that the |
@ViktorHofer thanks for the responsive reviewing! |
Fixes #53550
Based on #69455
With this change, when I build:
The new rid shows up in the packages:
@ericstj @ViktorHofer ptal.