Fix signature for 64-bit delegate profiling helper

[jakobbotsch]

I missed updating the signature of the 64-bit variant here when the
vtable and delegate profiling helpers were originally split up.

Fix #74295

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I missed updating the signature of the 64-bit variant here when the
vtable and delegate profiling helpers were originally split up.

Fix #74295

Author:	jakobbotsch
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[jakobbotsch]

I've added a JitRandomlyCollect64BitCounts and turned it on in the randomized PGO legs to get some testing for this mode.

cc @dotnet/jit-contrib PTAL @EgorBo @AndyAyersMS

[jakobbotsch]

/azp run runtime-coreclr pgo

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jakobbotsch]

Bunch of the runs seem to have been "dead-lettered".. will retry

[jakobbotsch]

/azp run runtime-coreclr pgo

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[markples]

Would it be worth devising a way for the compiler to assert that it has the right types (or at least number) of arguments for helper calls? Presumably these issues are going to be caught by normal testing, so it would be more a productivity thing, so is this kind of issue common?

[jakobbotsch]

Would it be worth devising a way for the compiler to assert that it has the right types (or at least number) of arguments for helper calls? Presumably these issues are going to be caught by normal testing, so it would be more a productivity thing, so is this kind of issue common?

I'm not sure if the effort would be worth it, I don't think I've seen this kind of mismatch before. But we should definitely ensure that we have testing to exercise all the helpers and the code in the JIT that builds the calls to them.

[jakobbotsch]

/azp run runtime-coreclr pgo

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JulieLeeMSFT]

@jakobbotsch are we going to backport this to 7.0?

[jakobbotsch]

@jakobbotsch are we going to backport this to 7.0?

Yes, I will backport this one.

[jakobbotsch]

/backport to release/7.0

[github-actions]

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2947516086