[release/7.0-rc1][mini] double quote linker path in defined(LD_NAME) case #74453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dotnet@e71a958 we started setting a default `LD_NAME` for x86 non-mach targets Fixes Android x86 builds that specify a `tool_prefix` with spaces in it
|
@carlossanlop this is a scenario blocker for MAUI in rc1 so we'll still need to take it. (there is also flow coming from emsdk #74456 ) |
lewing
approved these changes
Aug 23, 2022
|
cc @mmitche |
jeffschwMSFT
approved these changes
Aug 23, 2022
carlossanlop
approved these changes
Aug 24, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #74451 to
release/7.0-rc1Fixes a linking issue for Android x86 workloads
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1597564