Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Enable Dop_WorkersCreatedRespectingLimitAndTaskScheduler_Sync test #73486

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

steveisok
Copy link
Member

Fixes #50566

@ghost
Copy link

ghost commented Aug 5, 2022

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50566

Author: steveisok
Assignees: -
Labels:

area-System.Threading.Tasks

Milestone: -

@steveisok
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 5, 2022
@steveisok
Copy link
Member Author

Dop_WorkersCreatedRespectingLimitAndTaskScheduler_Sync(dop: -1) is the test that is failing on x64 and x86 emulators. Perhaps we just skip that test only?

@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 5, 2022
@mdh1418
Copy link
Member

mdh1418 commented Aug 6, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member

mdh1418 commented Aug 9, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member

mdh1418 commented Aug 9, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get another 👀 since I made the test change

@naricc naricc self-requested a review August 10, 2022 17:12
@akoeplinger
Copy link
Member

Failures are unrelated.

@akoeplinger akoeplinger merged commit fa75057 into dotnet:main Aug 10, 2022
@akoeplinger akoeplinger deleted the test-android-more branch August 10, 2022 19:19
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Threading.Tasks.Parallel.Tests fails on Android
4 participants