Update Arcade + Workloads #72947
Update Arcade + Workloads #72947
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned 
Yes, I'm going to set one up since that's where it failed last time |
| @@ -118,11 +118,6 @@ | |||
| <PublishFlatContainer>true</PublishFlatContainer> | |||
| </ItemsToPush> | |||
|
|
|||
| <ItemsToPush Include="@(WorkloadsVSInsertionFile)"> | |||
There was a problem hiding this comment.
After this is removed, where do the assets from the swix projects get picked up for publishing?
There was a problem hiding this comment.
😢 good point. I should probably add the new zip files to the item group
There was a problem hiding this comment.
I think I fixed this. The zips are unique named, so we can just put them in the same folder
|
Approved pending the official build looking good. |
It seems to be working: |
|
Publishing is fixed, but now it's looking for the individual files when signing that are no embedded inside a zip. @mmitche is there another way to lay out the files. The logs don't say where it's looking for the files, just that it can't find it under the artifacts. I suppose I can try to push the files individually and see if that works. |
|
@mmitche and I looked at a number of manifests from the internal builds against this branch. It appears all the artifacts are produced and everything should get signed like before. I'm not familiar with the runtime's tests that are failing. One seems to be related to Systerm.Data. Should I just try to rerun these? |
|
I'm not familiar with the failures, but the build analysis indicates that these are failing in release/6.0:
Do have another internal build for one last check? |
|
Rerunning the tests seem to work. @steveisok any idea who needs to sign off so we can merge this? |
|
@wtgodbe I assume we need to wait for branding changes before we can merge? |
|
Correct, this can be checked in after branding. @ericstj @ViktorHofer and @smasher164 will be handling merging runtime PRs will Carlos is OOF |
Update Arcade and the workloads project to leverage the new build tasks.
This also fixes the publishing issues we previously saw in the blob artifacts because of duplicate files. Instead, we'll create unique zip files per SDK featurebands for the workloads that will be used for creating the VSDROPs in dotnet-stage.