Add a test that ensures we are using SubtleCrypto in WASM crypto tests #72892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones |
|
The C# LGTM. The rest also LGTM, but in more of a nod-and-smile sort of way. |
radical
reviewed
Jul 27, 2022
src/libraries/System.Security.Cryptography/tests/wasm.helix.targets
Outdated
Show resolved
Hide resolved
radical
reviewed
Jul 27, 2022
radical
reviewed
Jul 27, 2022
radical
reviewed
Jul 27, 2022
src/libraries/System.Security.Cryptography/tests/System.Security.Cryptography.Tests.csproj
Outdated
Show resolved
Hide resolved
…ty.Cryptography.Tests.csproj
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
approved these changes
Jul 27, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Wasm failures are known, and unrelated to this PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69740