Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a static readonly int[] in System.Data.Common #72743

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Jul 24, 2022

There are a small number of values, all within the byte range.

Also renamed the consts to make it clearer (according to our style) that they are, since that matters for the span-based optimization.

(Last case extracted from #70179)

There are a small number of values, all within the byte range.
@ghost
Copy link

ghost commented Jul 24, 2022

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

There are a small number of values, all within the byte range.

Also renamed the consts to make it clearer (according to our style) that they are, since that matters for the span-based optimization.

Author: stephentoub
Assignees: -
Labels:

area-System.Data

Milestone: -

@stephentoub stephentoub added this to the 7.0.0 milestone Jul 24, 2022
@stephentoub stephentoub changed the title Replace a static readonly in[] in System.Data.Common Replace a static readonly int[] in System.Data.Common Jul 24, 2022
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure you're aware that this is the part of System.Data which is effectively archived (used only in DataTAble/DataSet), and micro-optimizing here is probably unlikely to have a significant overall effect.

@stephentoub
Copy link
Member Author

Yup, thanks. It's mainly to get it off my radar.

@stephentoub stephentoub merged commit 9f68db2 into dotnet:main Jul 24, 2022
@stephentoub stephentoub deleted the datacommonarrayspan branch July 24, 2022 20:36
@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants