Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #72709

Merged
merged 8 commits into from
Jul 24, 2022
Merged

Fix typos #72709

merged 8 commits into from
Jul 24, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Jul 23, 2022

No description provided.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 23, 2022
@ghost
Copy link

ghost commented Jul 23, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: am11
Assignees: -
Labels:

area-System.Reflection.Metadata
Milestone: -

@ghost
Copy link

ghost commented Jul 23, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: am11
Assignees: -
Labels:

area-Meta, community-contribution
Milestone: -

@am11 am11 requested a review from jkotas July 24, 2022 02:11
jkotas
jkotas approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 9d6396d into dotnet:main Jul 24, 2022
@am11 am11 deleted the fix/typos branch July 24, 2022 07:30
radical added a commit to radical/runtime that referenced this pull request Jul 25, 2022
@radical
[wasm][debugger] Fix test regressions
5bd85c3 
```
DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeWithUserBp(justMyCodeEnabled: False, debuggingFunction: "Debugger.stepInto", evalFunName: "RunStepThrough", functionNameCheck1: "StepThrougUserBp", line1: 841, col1: 8, functionNameCheck2: "RunStepThrough", line2: 848, col2: 4) [FAIL]
..
Expected: DebuggerAttribute.StepThrougUserBp
Actual:   DebuggerAttribute.StepThroughUserBp
```

And
```
[xUnit.net 00:08:39.10]     DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeResumeWithBp(justMyCodeEnabled: False, evalFunName: "RunStepThrough", decoratedFunName: "StepThrougBp") [FAIL]
  Failed DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeResumeWithBp(justMyCodeEnabled: False, evalFunName: "RunStepThrough", decoratedFunName: "StepThrougBp") [80 ms]
  Error Message:
   Assert.True() Failure
Expected: True
Actual:   False
  Stack Trace:
     at DebuggerTests.DebuggerTestBase.SetBreakpointInMethod(String assembly, String type, String method, Int32 lineOffset, Int32 col, String condition) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1096
   at DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeResumeWithBp(Boolean justMyCodeEnabled, String evalFunName, String decoratedFunName) in /_/src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs:line 668
--- End of stack trace from previous location ---
```

Caused by:
```
commit 9d6396d
Author: Adeel Mujahid <[email protected]>
Date:   Sun Jul 24 06:24:28 2022 +0300

    Fix typos (dotnet#72709)
```
ilonatommy added a commit that referenced this pull request Jul 25, 2022
@radical @ilonatommy
[wasm][debugger] Fix test regressions (#72751)
6bbaed4 
* [wasm][debugger] Fix test regressions

```
DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeWithUserBp(justMyCodeEnabled: False, debuggingFunction: "Debugger.stepInto", evalFunName: "RunStepThrough", functionNameCheck1: "StepThrougUserBp", line1: 841, col1: 8, functionNameCheck2: "RunStepThrough", line2: 848, col2: 4) [FAIL]
..
Expected: DebuggerAttribute.StepThrougUserBp
Actual:   DebuggerAttribute.StepThroughUserBp
```

And
```
[xUnit.net 00:08:39.10]     DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeResumeWithBp(justMyCodeEnabled: False, evalFunName: "RunStepThrough", decoratedFunName: "StepThrougBp") [FAIL]
  Failed DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeResumeWithBp(justMyCodeEnabled: False, evalFunName: "RunStepThrough", decoratedFunName: "StepThrougBp") [80 ms]
  Error Message:
   Assert.True() Failure
Expected: True
Actual:   False
  Stack Trace:
     at DebuggerTests.DebuggerTestBase.SetBreakpointInMethod(String assembly, String type, String method, Int32 lineOffset, Int32 col, String condition) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1096
   at DebuggerTests.BreakpointTests.StepThroughOrNonUserCodeAttributeResumeWithBp(Boolean justMyCodeEnabled, String evalFunName, String decoratedFunName) in /_/src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs:line 668
--- End of stack trace from previous location ---
```

Caused by:
```
commit 9d6396d
Author: Adeel Mujahid <[email protected]>
Date:   Sun Jul 24 06:24:28 2022 +0300

    Fix typos (#72709)
```

* Missing typo fixes.

Co-authored-by: Ilona Tomkowicz <[email protected]>
This was referenced Jul 25, 2022
Closed
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

@lambdageek lambdageek Awaiting requested review from lambdageek

@vargaz vargaz Awaiting requested review from vargaz

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@naricc naricc Awaiting requested review from naricc

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@lateralusX lateralusX Awaiting requested review from lateralusX lateralusX is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-Meta community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@am11 @jkotas