Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing System.Text.Json tests on Android x86 and on Browser with threading enabled #72664

Merged
merged 6 commits into from
Jul 22, 2022
Merged

Disable failing System.Text.Json tests on Android x86 and on Browser with threading enabled #72664

merged 6 commits into from
Jul 22, 2022

Conversation

simonrozsival
Copy link
Member

On Android x86, there is a problem with deserialization of doubles.
On Browser with multi-threading enabled, the System.Text.Json tests are timeouting.

This PR disables these tests.

Ref #72101
Ref #65723

/cc @radical

@ghost ghost assigned simonrozsival Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

On Android x86, there is a problem with deserialization of doubles.
On Browser with multi-threading enabled, the System.Text.Json tests are timeouting.

This PR disables these tests.

Ref #72101
Ref #65723

/cc @radical

Author: simonrozsival
Assignees: -
Labels:

arch-wasm, arch-x86, area-System.Text.Json, os-android
Milestone: -

@simonrozsival
Copy link
Member Author

/azp run runtime-extra-platforms

@ghost
Copy link

ghost commented Jul 22, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

On Android x86, there is a problem with deserialization of doubles.
On Browser with multi-threading enabled, the System.Text.Json tests are timeouting.

This PR disables these tests.

Ref #72101
Ref #65723

/cc @radical

Author: simonrozsival
Assignees: -
Labels:

arch-wasm, arch-x86, area-System.Text.Json, os-android
Milestone: -

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

krwq
krwq approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure those are the only tests failing? (or most frequent) AFAIK most of our intermittent failures used to happen in random tests and random tests happened to manifest the issue. Approving since this is scoped to Android X86

@radical
Copy link
Member

radical commented Jul 22, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simonrozsival
Copy link
Member Author

@krwq The tests seem to fail quite consistently on Android x86. I've only disabled the tests that appear in logs referenced in #72101. I'm still looking for more flaky tests that could be related, that's why the PR is still a draft.

@simonrozsival
Copy link
Member Author

/azp run runtime-extra-platforms

@simonrozsival
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simonrozsival
Copy link
Member Author

/azp run runtime-extra-platforms

@simonrozsival
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 22, 2022
Closed
Open
@simonrozsival
Copy link
Member Author

/azp run runtime-extra-platforms

@simonrozsival
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing
Copy link
Member

lewing commented Jul 22, 2022

cc @karelz

@simonrozsival simonrozsival marked this pull request as ready for review July 22, 2022 18:29
@simonrozsival simonrozsival merged commit 391d143 into dotnet:main Jul 22, 2022
@runfoapp runfoapp bot mentioned this pull request Jul 25, 2022
Closed
@simonrozsival simonrozsival mentioned this pull request Jul 26, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees

@simonrozsival simonrozsival

Labels
arch-wasm WebAssembly architecture arch-x86 area-System.Text.Json os-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simonrozsival @radical @lewing @krwq @stephentoub