Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Fix hang caused by calling Environment.FailFast on multiple threads #72567

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 21, 2022

Backport of #72566 to release/6.0

/cc @jkotas

Customer Impact

Crashing process hangs instead of exiting. It prevents crashing service to recover gracefully without unnecessary delay.

Testing

Targeted repro

Risk

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@teo-tsirpanis teo-tsirpanis added this to the 6.0.x milestone Jul 21, 2022
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We will take for consideration in 6.0.x.

cc @JulieLeeMSFT

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Jul 21, 2022
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 21, 2022
@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.9 Jul 21, 2022
@carlossanlop
Copy link
Member

@jkotas @trylek @mangod9 there is a CI leg that timed out and got cancelled. Looking at the title of this PR, do you think it is possible the failure is related?

Confirming this is the only thing left for me to merge this.

@jkotas
Copy link
Member

jkotas commented Aug 11, 2022

there is a CI leg that timed out and got cancelled. Looking at the title of this PR, do you think it is possible the failure is related?

It is not related. It timed out during the build:

[ 93%] Linking CXX shared library libclrjit_win_x86_arm64.dylib
##[error]The operation was canceled

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tactics approved.
Correct milestone applied.
CI failure is confirmed to be unrelated.
No OOB package authoring needed (native code).
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 0f6284e into release/6.0 Aug 12, 2022
@carlossanlop carlossanlop deleted the backport/pr-72566-to-release/6.0 branch August 12, 2022 18:58
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants