-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Fix hang caused by calling Environment.FailFast on multiple threads #72567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. We will take for consideration in 6.0.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is not related. It timed out during the build:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tactics approved.
Correct milestone applied.
CI failure is confirmed to be unrelated.
No OOB package authoring needed (native code).
Ready to merge.
Backport of #72566 to release/6.0
/cc @jkotas
Customer Impact
Crashing process hangs instead of exiting. It prevents crashing service to recover gracefully without unnecessary delay.
Testing
Targeted repro
Risk
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.