Ensure metadata originating from converters is surfaced while JsonTypeInfo is mutable. #72483
Conversation
…eInfo is mutable.
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsDiscovered while investigating #60560. Some of our internal converter implementations use the Contributes to #63686.
|
| @@ -27,7 +28,7 @@ internal override object CreateObject(JsonSerializerOptions options) | |||
| JsonObject jObject = (JsonObject)obj; | |||
|
|
|||
| Debug.Assert(value == null || value is JsonNode); | |||
| JsonNode? jNodeValue = (JsonNode?)value; | |||
| JsonNode? jNodeValue = value; | |||
There was a problem hiding this comment.
nit: consider removing assert above
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverter.cs
Show resolved
Hide resolved
...ystem.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.HandlePropertyName.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
...s/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonObjectConverter.cs
Show resolved
Hide resolved
...ies/System.Text.Json/src/System/Text/Json/Serialization/Metadata/SourceGenJsonTypeInfoOfT.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Discovered while investigating #60560.
Some of our internal converter implementations override the
JsonConverter.ConfigureJsonTypeInfomethod when needing to modify contract metadata. Currently, this configuration step is run after the metadata instance gets locked, so none of these changes are visible to contract resolver authors. This PR changes this so that the method in question is invoked at metadata construction time, and only when said metadata originates fromDefaultJsonTypeInfoResolverorJsonSerializerContext.Contributes to #63686.