-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RateLimiting] Add statistics API #72306
Conversation
Tagging subscribers to this area: @mangod9 Issue DetailsCloses #71804 I could be convinced that the chained rate limiter should use the largest queue count instead of the smallest. Also, the NoopLimiter could technically keep track of the successful leases and update the stats for that property.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
src/libraries/System.Threading.RateLimiting/ref/System.Threading.RateLimiting.cs
Show resolved
Hide resolved
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Outdated
Show resolved
Hide resolved
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Outdated
Show resolved
Hide resolved
...raries/System.Threading.RateLimiting/src/System/Threading/RateLimiting/ConcurrencyLimiter.cs
Show resolved
Hide resolved
src/libraries/System.Threading.RateLimiting/src/System/Threading/RateLimiting/NoopLimiter.cs
Outdated
Show resolved
Hide resolved
37a2bc3
to
900a56c
Compare
900a56c
to
83d46c2
Compare
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Show resolved
Hide resolved
...em.Threading.RateLimiting/src/System/Threading/RateLimiting/ChainedPartitionedRateLimiter.cs
Outdated
Show resolved
Hide resolved
177c35c
to
955f12c
Compare
Closes #71804
I could be convinced that the chained rate limiter should use the largest queue count instead of the smallest.
Also, the NoopLimiter could technically keep track of the successful leases and update the stats for that property.