Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unix] Console.ReadKey rewrite #72193

Merged
merged 42 commits into from
Aug 1, 2022
Merged

[Unix] Console.ReadKey rewrite #72193

merged 42 commits into from
Aug 1, 2022

Commits on Jun 28, 2022

  1. move WellKnownStrings to a separate file

    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    d929235 View commit details
    Browse the repository at this point in the history

  2. move Database to separate file

    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c8887ec View commit details
    Browse the repository at this point in the history

  3. move factory logic to DatabaseFactory so the test project does not ne… 

    …ed to reference all sys-calls used for reading files
    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    cf77107 View commit details
    Browse the repository at this point in the history

  4. move WellKnownNumbers to separate file

    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c6f3a60 View commit details
    Browse the repository at this point in the history

  5. include Database in the test project

    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    acd4f24 View commit details
    Browse the repository at this point in the history

  6. move TerminalFormatStrings to a separate file

    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    f5e3641 View commit details
    Browse the repository at this point in the history

  7. include TerminalFormatStrings in test project

    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    d3cdb93 View commit details
    Browse the repository at this point in the history

  8. fix existing tests

    @adamsitnik
    adamsitnik committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    7ea9f50 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. move the key mapping logic to a separate class, do NOT change it

    @adamsitnik
    adamsitnik committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    dc0af6b View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. simple tests for ASCII characters

    @adamsitnik
    adamsitnik committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    c927091 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. test cases for xterm and xterm-256color

    @adamsitnik
    adamsitnik committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    f30f02e View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. add PuTTY and UXTern

    @adamsitnik
    adamsitnik committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    5ffdd67 View commit details
    Browse the repository at this point in the history

  2. add Windows Terminal data

    @adamsitnik
    adamsitnik committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9230c81 View commit details
    Browse the repository at this point in the history

  3. add more PuTTY test cases

    @adamsitnik
    adamsitnik committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    41a92bf View commit details
    Browse the repository at this point in the history

  4. handle empty encodings

    @adamsitnik
    adamsitnik committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    af92ab3 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. make it possible to run the tests on Windows so I can use my favourit… 

    …e dev env
    @adamsitnik
    adamsitnik committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9a2ed71 View commit details
    Browse the repository at this point in the history

  2. add mappings for single characters

    @adamsitnik
    adamsitnik committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    69f12c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. add mappings for 3 characters

    @adamsitnik
    adamsitnik committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    5bbac1d View commit details
    Browse the repository at this point in the history

  2. fix test cases where pressing Ctrl/Alt/Shift + other key produces two… 

    … bytes which represent single UTF8 character by design
    @adamsitnik
    adamsitnik committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    a9db7db View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. handle more complex sequences (with modifiers)

    @adamsitnik
    adamsitnik committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    c2e02d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. handle edge cases properly

    @adamsitnik
    adamsitnik committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    620d1a0 View commit details
    Browse the repository at this point in the history

  2. add tmux test data

    @adamsitnik
    adamsitnik committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    20593ef View commit details
    Browse the repository at this point in the history

  3. add rxvt-unicode test data and implementation for rxvt modifiers

    @adamsitnik
    adamsitnik committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    c612f4f View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. polishing

    @adamsitnik
    adamsitnik committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    3e62636 View commit details
    Browse the repository at this point in the history

  2. switch to the new implementation and allow the users to differentiate… 

    … between Enter (\r) and Ctrl+Enter (\n) like we do on Windows
    @adamsitnik
    adamsitnik committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    aa07430 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. add way more test cases and fix identified issues 

    remove UXTerm as its the same as Term
    @adamsitnik
    adamsitnik committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    254c762 View commit details
    Browse the repository at this point in the history

  2. polishing: reorder the tests

    @adamsitnik
    adamsitnik committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4023725 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. fix compiler error (it's strange as I was not getting it when I was b… 

    …uilding Console solution only)
    @adamsitnik
    adamsitnik committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    d65c6e7 View commit details
    Browse the repository at this point in the history

  2. add more SCO mappings

    @adamsitnik
    adamsitnik committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    8cd9e3d View commit details
    Browse the repository at this point in the history

  3. Numeric Keypad

    @adamsitnik
    adamsitnik committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    7fea037 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into consoleReadKey 

    # Conflicts:
#	src/libraries/System.Console/src/System/IO/StdInReader.cs
#	src/libraries/System.Console/src/System/TermInfo.cs
    @adamsitnik
    adamsitnik committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    16e983f View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. add Tmux 256 color test cases (TERM=screen-256color)

    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    dd07418 View commit details
    Browse the repository at this point in the history

  2. add two Numeric Keypad test cases: period & Enter

    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    632267c View commit details
    Browse the repository at this point in the history

  3. fix issue discovered by adding more tmux test cases: ^[OM should be m… 

    …apped to Enter
    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    69f6434 View commit details
    Browse the repository at this point in the history

  4. address code review feedback: move TerminalFormatStrings classs out i… 

    …f ConsolePal
    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    9c352b4 View commit details
    Browse the repository at this point in the history

  5. address code review feedback: handle all variants of tmux when gettin… 

    …g title
    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    f974992 View commit details
    Browse the repository at this point in the history

  6. address code review feedback: reduce number of out parameters

    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    b3366a8 View commit details
    Browse the repository at this point in the history

  7. fix TermInfo tests

    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    dc82fb5 View commit details
    Browse the repository at this point in the history

  8. add .NET 6 compat switch

    @adamsitnik
    adamsitnik committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    214da94 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Apply suggestions from code review 

    Co-authored-by: David Cantú <[email protected]>
    @adamsitnik @jozkee
    adamsitnik and jozkee authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    7766ed3 View commit details
    Browse the repository at this point in the history

  2. address code review feedback

    @adamsitnik
    adamsitnik committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c8010c5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into consoleReadKey

    @adamsitnik
    adamsitnik authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c28d600 View commit details
    Browse the repository at this point in the history