Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add runtime-wasm-perf pipeline #72119

Merged
merged 12 commits into from
Jul 26, 2022
Merged

[wasm] Add runtime-wasm-perf pipeline #72119

merged 12 commits into from
Jul 26, 2022

Conversation

radical
Copy link
Member

@radical radical commented Jul 13, 2022

  • This adds a new runtime-wasm-perf pipeline, which can be run manually with /azp run runtime-wasm-perf

  • Essentially, splits the perf jobs into perf-wasm-jobs.yml, and perf-non-wasm-jobs.yml

  • It does not change the existing perf pipeline

  • this will run all the wasm benchmarks, but it doesn't support comparing results yet

  • A follow up PR will add perf jobs to the runtime pipelines, for sanity check, and won't run the full set of benchmarks.

@radical radical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Jul 13, 2022
@radical
Copy link
Member Author

radical commented Jul 13, 2022

/azp run perf-wasm

@ghost ghost assigned radical Jul 13, 2022
@ghost
Copy link

ghost commented Jul 13, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 13, 2022

/azp run perf-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 13, 2022

/azp run perf-wasm

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 13, 2022

/azp run perf-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 13, 2022

/azp run perf-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 14, 2022

/azp run runtime-wasm,perf-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 15, 2022

/azp run perf-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical force-pushed the perf-manual branch 2 times, most recently from 4f36df2 to 5a679c2 Compare July 15, 2022 00:58
@radical radical requested review from lewing and LoopedBard3 July 15, 2022 01:00
@radical
Copy link
Member Author

radical commented Jul 15, 2022

Internal pipeline has a build for this branch - 20220714.9.

@lewing
Copy link
Member

lewing commented Jul 18, 2022

This seems useful, is there any reason not to do it?

@radical
Copy link
Member Author

radical commented Jul 18, 2022

/azp run perf-wasm

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 18, 2022

This seems useful, is there any reason not to do it?

I didn't add it to runtime by default was because it has it's own wasm build job, which duplicates the builds done by other wasm jobs. So, I'm working on a PR to use a few common builds, and then run tests, and perf based on that.

@radical
Copy link
Member Author

radical commented Jul 18, 2022

/azp run perf-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 18, 2022

So, I'm working on a PR to use a few common builds, and then run tests, and perf based on that.

.. but this will be helpful irrespective, by running manually /azp run perf-wasm.

@radical
Copy link
Member Author

radical commented Jul 19, 2022

dotnet-runtime-perf's build 20220718.5 corresponds to the HEAD of this branch, after merging main.

@radical
Copy link
Member Author

radical commented Jul 20, 2022

@akoeplinger @DrewScoggins any thoughts on this?

@akoeplinger
Copy link
Member

@radical looks good but I'd prefer the AzDO pipeline name to be runtime-wasm-perf which is more consistent with the runtime-wasm pipeline name (and also closer to the dotnet-runtime-perf name in the internal AzDO).

@radical
Copy link
Member Author

radical commented Jul 26, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 26, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical changed the title [wasm] Add perf-wasm pipeline [wasm] Add runtime-wasm-perf pipeline Jul 26, 2022
@radical
Copy link
Member Author

radical commented Jul 26, 2022

Confirmed that the pipeline can be triggered by the new name. And it doesn't affect dotnet-runtime-perf.
Waiting for other builds now.

@radical radical merged commit aa5ff31 into dotnet:main Jul 26, 2022
@radical radical deleted the perf-manual branch July 26, 2022 23:18
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants