Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix solution files via slngen #72059

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Fix solution files via slngen #72059

merged 3 commits into from
Jul 13, 2022

Conversation

pavelsavara
Copy link
Member

Fixes #72052

@pavelsavara pavelsavara added this to the 7.0.0 milestone Jul 12, 2022
@pavelsavara pavelsavara self-assigned this Jul 12, 2022
@pavelsavara
Copy link
Member Author

Should the solutions like HTTP have dependency on the new System.Runtime.InteropServices.JavaScript and JSImportGenerator assemblies ?
They are used only when building for Browser target and that never works for me in the VS anyway.

@pavelsavara pavelsavara requested review from lewing and radical July 13, 2022 05:59
@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 13, 2022 •
edited by pavelsavara
Loading

Should the solutions like HTTP have dependency on the new System.Runtime.InteropServices.JavaScript and JSImportGenerator assemblies ?
They are used only when building for Browser target and that never works for me in the VS anyway.

Solution files are auto-generated via the slngen tooling which automatically detects which projects need to be inside a solution. Please run dotnet.cmd build src/libraries/slngen.proj to re-generate all solution files. There might be a few unrelated changes but that's OK.

@pavelsavara pavelsavara changed the title Remove System.Private.Runtime.InteropServices.JavaScript from solutions Fix solution files via slngen Jul 13, 2022
@pavelsavara
Copy link
Member Author

Thanks, I didn't know we have that tool!

There might be a few unrelated changes but that's OK.

There are quite "few" :-)

@pavelsavara pavelsavara requested a review from ViktorHofer July 13, 2022 09:13
@ViktorHofer
Copy link
Member

19 is actually not that much :) Thanks for updating.

@ViktorHofer ViktorHofer merged commit 5acae80 into dotnet:main Jul 13, 2022
@pavelsavara pavelsavara deleted the wasm_fix_sln branch July 14, 2022 20:47
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@ManickaP ManickaP Awaiting requested review from ManickaP

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@radical radical Awaiting requested review from radical

Assignees

@pavelsavara pavelsavara

Labels
area-Build-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[JSInterop] cannot build System.Net.Http.sln
2 participants
@pavelsavara @ViktorHofer