Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark JsonSerializerOptions.TypeInfoResolver as nullable and linker-safe #72044

Conversation

eiriktsarpalis
Copy link
Member

Fix #71960.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 12, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #71960.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: 7.0.0

@eiriktsarpalis eiriktsarpalis merged commit f0fe390 into dotnet:main Jul 13, 2022
@eiriktsarpalis eiriktsarpalis deleted the jsonserializeroptions-jsontypeinfo-nullability branch July 13, 2022 10:03
@eiriktsarpalis
Copy link
Member Author

/backport to release/7.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/7.0-preview7: https://github.com/dotnet/runtime/actions/runs/2662623243

@dotnet dotnet deleted a comment from github-actions bot Jul 13, 2022
@dotnet dotnet deleted a comment from github-actions bot Jul 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The JsonSerializerOptions.TypeInfoResolver property should be nullable
3 participants