-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the approved span marshallers and remove the v1 model #71989
Conversation
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThis PR builds on #71978 and adds the approved span marshaller shapes. Since we will no longer have usage of the v1 marshalling model, this PR also removes it entirely. This PR would replace #71980, but that one should be merged if this one isn't ready by P7. If this PR misses P7, we need to add type forwarders for the types moved between the ref assemblies. In combination with the referenced PRs, this PR fixes #70859 Fixes #69281
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
@jkoritzinsky, so once this PR is in, we can start using spans (unadorned) in LibraryImport methods? |
@stephentoub Yes! I'd update places to use this now, but I want to try to get this in for P7 if possible. |
… types to System.Runtime ref assembly
…upport this and it was breaking the span marshallers.
You served us well, but your time has passed.
3fd16f6
to
1ad0f2e
Compare
...tem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ReadOnlySpanMarshaller.cs
Show resolved
Hide resolved
...tem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ReadOnlySpanMarshaller.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/Compiles.cs
Outdated
Show resolved
Hide resolved
…'t support this with the v2 system.
The failing test should be deleted. I have a commit locally. That deletes the test, but I'm going to let CI keep running to see if there's anything else that fails. If this is the only failure, I'll push up the change to delete the test and then merge the PR. That way we don't get this PR stuck waiting for machines to run tests when we want to get it in before P7 branches off. |
Okay all of the test failures are the expected failure. |
This PR builds on #71978 and adds the approved span marshaller shapes. Since we will no longer have usage of the v1 marshalling model, this PR also removes it entirely.
This PR would replace #71980, but that one should be merged if this one isn't ready by P7. If this PR misses P7, we need to add type forwarders for the types moved between the ref assemblies.
In combination with the referenced PRs, this PR fixes #70859
Fixes #69281