Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing APIs to contract customization #71797

Merged

Conversation

eiriktsarpalis
Copy link
Member

Fix #71123. Contributes to #63686.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis requested a review from krwq July 8, 2022 00:40
@eiriktsarpalis eiriktsarpalis self-assigned this Jul 8, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Jul 8, 2022
@ghost
Copy link

ghost commented Jul 8, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #71123. Contributes to #63686.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

@krwq
Copy link
Member

krwq commented Jul 8, 2022

There are couple of things left here:

  • fix functional tests to use patterns we recommend to users (i.e. whenever calling Properties.Clear() we should be creating types from scratch and combining)
  • we should not pre-sort properties for reflection
  • allow users to fix extension data on properties of wrong type/attribute on two properties + functional tests
  • fix docs on GetConverter w.r.t null/throw and make sure we match behavior in GetTypeInfo

I'm ok with fixing that later but we need to track remaining work somewhere. Otherwise looks good

@eiriktsarpalis
Copy link
Member Author

There are couple of things left here:

  • fix functional tests to use patterns we recommend to users (i.e. whenever calling Properties.Clear() we should be creating types from scratch and combining)
  • we should not pre-sort properties for reflection
  • allow users to fix extension data on properties of wrong type/attribute on two properties + functional tests
  • fix docs on GetConverter w.r.t null/throw and make sure we match behavior in GetTypeInfo

I'm ok with fixing that later but we need to track remaining work somewhere. Otherwise looks good

As a matter of record, I will reiterate that these concerns have either been addressed, need not be addressed in the scope of this change or will not be addressed by design. Individual remarks elaborate these points further. This PR is ready for sign-off.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there are still some open discussions on this, each of them that was agreed to be addressed later has a backing issue and doesn't affect the raw functionality as best as I can tell. Let's go ahead and get this in ahead of the weekend.

@eiriktsarpalis eiriktsarpalis merged commit 2f7fdb9 into dotnet:main Jul 8, 2022
@eiriktsarpalis eiriktsarpalis deleted the contract-resolver-missing-apis branch July 8, 2022 18:45
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add APIs to JSON Contract customization
3 participants