-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update design and expose new attributes for the CustomTypeMarshaller support #71682
Conversation
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsUpdate the design of the V2 marshallers based on API review feedback. Expose the Contributes to #70859
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
docs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md
Outdated
Show resolved
Hide resolved
docs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md
Outdated
Show resolved
Hide resolved
....Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/CustomMarshallerAttribute.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Outdated
Show resolved
Hide resolved
...ies/System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/MarshallerShape.cs
Show resolved
Hide resolved
...braries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/MarshalMode.cs
Outdated
Show resolved
Hide resolved
Failures are a network blip and #71684 |
Update the design of the V2 marshallers based on API review feedback.
Expose the
CustomTypeMarshallerAttribute
class and theMarshalMode
enum so we can use them to update ASP.NET Core's custom marshallers and delete the V1 model sooner.Also block the analyzer from warning on the V2 design for now until we actually get it updated.
Contributes to #70859