Basic support for stateless linear collection marshalling #71473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThis plumbs through the element information we need for linear collection marshallers and adds basic stateless support. Only blittable elements are handled in this change. Not handled:
Generated example[LibraryImport("lib")]
[return: MarshalUsing(typeof(CustomArrayMarshaller<,>), CountElementName = "numValues")]
public static partial int[] Method(
[MarshalUsing(typeof(CustomArrayMarshaller<,>))] int[] values,
out int numValues);
public static partial int[] Method(int[] values, out int numValues)
{
System.Runtime.CompilerServices.Unsafe.SkipInit(out numValues);
byte* __values_native;
int[] __retVal;
byte* __retVal_native;
// Setup - Perform required setup.
int __retVal_native__numElements;
int __values_native__numElements;
// Marshal - Convert managed data to native data.
__values_native = global::SharedTypes.CustomArrayMarshaller<int, int>.AllocateContainerForUnmanagedElements(values, out __values_native__numElements);
global::SharedTypes.CustomArrayMarshaller<int, int>.GetManagedValuesSource(values).CopyTo(global::SharedTypes.CustomArrayMarshaller<int, int>.GetUnmanagedValuesDestination(__values_native, __values_native__numElements));
// Pin - Pin data in preparation for calling the P/Invoke.
fixed (int* __numValues_native = &numValues)
{
__retVal_native = __PInvoke(__values_native, __numValues_native);
}
// Unmarshal - Convert native data to managed data.
__retVal_native__numElements = checked((int)(numValues));
__retVal = global::SharedTypes.CustomArrayMarshaller<int, int>.AllocateContainerForManagedElements(__retVal_native, __retVal_native__numElements);
global::SharedTypes.CustomArrayMarshaller<int, int>.GetUnmanagedValuesSource(__retVal_native, __retVal_native__numElements).CopyTo(global::SharedTypes.CustomArrayMarshaller<int, int>.GetManagedValuesDestination(__retVal));
return __retVal;
// Local P/Invoke
[System.Runtime.InteropServices.DllImportAttribute("Microsoft.Interop.Tests.NativeExportsNE", EntryPoint = "sum_int_array", ExactSpelling = true)]
static extern unsafe byte* __PInvoke(byte* values, int* numValues);
}
[LibraryImport("lib")]
[return: MarshalUsing(typeof(ListMarshaller<,>), CountElementName = "numValues")]
public static partial List<int> Method(
[MarshalUsing(typeof(ListMarshaller<,>))] List<int> values,
out int numValues);
public static partial global::System.Collections.Generic.List<int> Method(global::System.Collections.Generic.List<int> values, out int numValues)
{
System.Runtime.CompilerServices.Unsafe.SkipInit(out numValues);
byte* __values_native;
global::System.Collections.Generic.List<int> __retVal;
byte* __retVal_native;
// Setup - Perform required setup.
int __retVal_native__numElements;
int __values_native__numElements;
// Marshal - Convert managed data to native data.
__values_native = global::SharedTypes.ListMarshaller<int, int>.AllocateContainerForUnmanagedElements(values, out __values_native__numElements);
global::SharedTypes.ListMarshaller<int, int>.GetManagedValuesSource(values).CopyTo(global::SharedTypes.ListMarshaller<int, int>.GetUnmanagedValuesDestination(__values_native, __values_native__numElements));
// Pin - Pin data in preparation for calling the P/Invoke.
fixed (int* __numValues_native = &numValues)
{
__retVal_native = __PInvoke(__values_native, __numValues_native);
}
// Unmarshal - Convert native data to managed data.
__retVal_native__numElements = checked((int)(numValues));
__retVal = global::SharedTypes.ListMarshaller<int, int>.AllocateContainerForManagedElements(__retVal_native, __retVal_native__numElements);
global::SharedTypes.ListMarshaller<int, int>.GetUnmanagedValuesSource(__retVal_native, __retVal_native__numElements).CopyTo(global::SharedTypes.ListMarshaller<int, int>.GetManagedValuesDestination(__retVal));
return __retVal;
// Local P/Invoke
[System.Runtime.InteropServices.DllImportAttribute("Microsoft.Interop.Tests.NativeExportsNE", EntryPoint = "sum_int_array", ExactSpelling = true)]
static extern unsafe byte* __PInvoke(byte* values, int* numValues);
}
|
Not handled: - caller-allocated buffer - guaranteed unmarshal - pinnable reference - non-blittable element marshalling - element scenarios on custom marshallers
elinor-fung
force-pushed
the
basicStatelessCollection
branch
from
c731b9a to
d1f8d32
Compare
jkoritzinsky
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plumbs through the element information we need for linear collection marshallers and adds basic stateless support. Only blittable elements are handled in this change.
Not handled:
Generated example