-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix some System.Net tests #71385
[Android] Fix some System.Net tests #71385
Conversation
…tem-net-security-tests-on-android
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThis PR fixes most of the tests that were disabled in #68206. We use some self-signed certificates in our tests and Android doesn't allow traffic to the servers using those certificates. In order to get the tests to work, we need to configure include the public keys in the .apk we build and use Network Security Configuration to trust our self-signed certificates.
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
The tests pass on Android devices (arm and arm64 lanes) and fail on emulators (x86 and x64 lanes). I'm converting this PR to a draft until I figure out why. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
…logs" This reverts commit 039d051.
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
…tem-net-security-tests-on-android
/azp run runtime-extra-platforms |
1 similar comment
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
…tem-net-security-tests-on-android
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
All of the failing tests are know issues and are also happening on main. This PR is now ready to be merged. |
We use some self-signed certificates in our tests and Android doesn't allow traffic to the servers using those certificates. In order to get the tests to work, we need to configure include the public keys in the .apk we build and use Network Security Configuration to trust our self-signed certificates.
Closes #37087
Fixes most of #68206
Closes #69870
Fixes Android-related failures in #72209