Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark EnumerateMetafileProc's callbackData parameter as nullable #71239

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

jkoritzinsky
Copy link
Member

Follow up to #71225

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @dotnet/area-system-drawing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up to #71225

Author: jkoritzinsky
Assignees: jkoritzinsky
Labels:

area-System.Drawing, new-api-needs-documentation

Milestone: -

@stephentoub
Copy link
Member

Any idea why Graphics.cs is showing as every line having been edited?
image

@jkoritzinsky
Copy link
Member Author

No clue. I edited it on the online editor. I'll retry the change from a local clone tomorrow.

@jkotas
Copy link
Member

jkotas commented Jun 24, 2022

Any idea why Graphics.cs is showing as every line having been edited?

Unix newlines got converted to Windows newlines. You can tell by looking at the file size on Unix or by opening the file on Unix in editor that is able to show the difference. You won't see any difference on Windows if you use default git settings. git converts Unix new lines to Windows new lines behind the scenes on Windows by default.

jkotas@jkotas11:~/runtime/src/libraries/System.Drawing.Common/src/System/Drawing$ ls -la Graphics.cs
-rw-r--r-- 1 jkotas jkotas 128939 Jun 23 22:01 Graphics.cs
jkotas@jkotas11:~/runtime/src/libraries/System.Drawing.Common/src/System/Drawing$ git checkout nullable-callbackdata
Switched to branch 'nullable-callbackdata'
Your branch is up to date with 'upstream/nullable-callbackdata'.
jkotas@jkotas11:~/runtime/src/libraries/System.Drawing.Common/src/System/Drawing$ ls -la Graphics.cs
-rw-r--r-- 1 jkotas jkotas 132393 Jun 23 22:02 Graphics.cs

@stephentoub stephentoub force-pushed the nullable-callbackdata branch from 88bfa8e to dbc543a Compare June 24, 2022 14:07
@stephentoub
Copy link
Member

I fixed it.

@jkoritzinsky
Copy link
Member Author

Failures are #70969 and #70549 (comment)

@jkoritzinsky jkoritzinsky merged commit d58c5cc into main Jun 24, 2022
@jkoritzinsky jkoritzinsky deleted the nullable-callbackdata branch June 24, 2022 17:22
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants