Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default log color behavior when console is redirected #70504

Merged
merged 7 commits into from
Jun 20, 2022
Merged

Fix default log color behavior when console is redirected #70504

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04347cb
Fix default log color behavior when console is redirected
maryamariyan Jun 9, 2022
34d11cd
Add test
maryamariyan Jun 14, 2022
e487666
Simplify test
maryamariyan Jun 14, 2022
e21d93e
Apply PR feedback
maryamariyan Jun 15, 2022
e3cb016
Move EmitAnsiColorCodes to Common
maryamariyan Jun 17, 2022
85ef789
Apply suggestions from code review
maryamariyan Jun 17, 2022
1f9bcd5
Update src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleC…
maryamariyan Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLoggerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,14 @@ public ILogger CreateLogger(string name)
#pragma warning disable CS0618
private static void UpdateFormatterOptions(ConsoleFormatter formatter, ConsoleLoggerOptions deprecatedFromOptions)
{
bool disableColors = deprecatedFromOptions.DisableColors || System.Console.IsOutputRedirected;
maryamariyan marked this conversation as resolved.
Show resolved Hide resolved
maryamariyan marked this conversation as resolved.
Show resolved Hide resolved

maryamariyan marked this conversation as resolved.
Show resolved Hide resolved
// kept for deprecated apis:
if (formatter is SimpleConsoleFormatter defaultFormatter)
{
defaultFormatter.FormatterOptions = new SimpleConsoleFormatterOptions()
{
ColorBehavior = deprecatedFromOptions.DisableColors ? LoggerColorBehavior.Disabled : LoggerColorBehavior.Enabled,
ColorBehavior = disableColors ? LoggerColorBehavior.Disabled : LoggerColorBehavior.Enabled,
maryamariyan marked this conversation as resolved.
Show resolved Hide resolved
IncludeScopes = deprecatedFromOptions.IncludeScopes,
TimestampFormat = deprecatedFromOptions.TimestampFormat,
UseUtcTimestamp = deprecatedFromOptions.UseUtcTimestamp,
Expand Down