Add basic testing infrastructure in NativeAOT (port from dotnet/linker) #70408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tlakollo
commented
Jun 7, 2022
•
tlakollo
commented
- Port the Mono.Linker.Tests* projects from dotnet/linker
- Add the new projects to .editorconfig so they remain under the dotnet/linker format instead of dotnet/runtime
- clr.toolstests subset now runs the Mono.Linker.Tests infrastructure
- Make DisplayNameHelpers a public class so it can be used by the test infrastructure
- Add a couple of simple test cases (Dataflow and Requires) along with a Repro test, just like the repro project the repro test serves prototyping purposes
- Adds ProducedBy.NativeAOT to be able to represent differences between dotnet/linker and NativeAOT (either because of a bug or because NativeAOT correctly produces additional warnings)
Add the new projects to .editorconfig so they remain under the dotnet/linker format instead of dotnet/runtime clr.toolstests subset now runs the Mono.Linker.Tests infrastructure Make DisplayNameHelpers a public class so it can be used by the test infrastructure Add couple of simple test cases
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
verifiable Remove deleted folder structures set in TestDatabase
6 tasks
vitek-karas
reviewed
Jun 8, 2022
| { | ||
| private const string DefaultSystemModule = "System.Private.CoreLib"; | ||
|
|
||
| public void Trim (ILCompilerOptions options, ILogWriter logWriter) |
There was a problem hiding this comment.
@MichalStrehovsky could you please review this method? It's basically the main part of this change - this runs enough of the ILScanner to get diagnostics.
The rest of this change is mostly making stuff work in XUnit and test adaptations.
There was a problem hiding this comment.
Looks good to me.
We could potentially simplify things here:
- I don't think OS/arch matters at all - we could just say we're compiling for x64 Windows and be done with it - if we keep the logic to detect it, it will need fixes whenever a new OS/arch is adde)
- The list of InitAssemblies probably doesn't matter and we could skip that. JanK is deleting various System.Private assemblies so having this list just means more things to fix up.
src/coreclr/tools/aot/Mono.Linker.Tests/Mono.Linker.Tests.csproj
Outdated
Show resolved
Hide resolved
| { | ||
| private const string DefaultSystemModule = "System.Private.CoreLib"; | ||
|
|
||
| public void Trim (ILCompilerOptions options, ILogWriter logWriter) |
There was a problem hiding this comment.
Looks good to me.
We could potentially simplify things here:
- I don't think OS/arch matters at all - we could just say we're compiling for x64 Windows and be done with it - if we keep the logic to detect it, it will need fixes whenever a new OS/arch is adde)
- The list of InitAssemblies probably doesn't matter and we could skip that. JanK is deleting various System.Private assemblies so having this list just means more things to fix up.
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.