Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix Wasm.Build.Tests test failures on windows #70328

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

radical
Copy link
Member

@radical radical commented Jun 7, 2022

Fixes #69860 .

Issue - emscripten-core/emscripten#15146

Emscripten added a workaround enabled by setting
the environment variable - `EM_WORKAROUND_PYTHON_BUG_34780`.
.. to avoid conflicting with other instances on helix.
@ghost ghost assigned radical Jun 7, 2022
@radical radical added arch-wasm WebAssembly architecture test-bug Problem in test source code (most likely) and removed area-Build-mono labels Jun 7, 2022
@ghost
Copy link

ghost commented Jun 7, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Enable workaround for a python issue - EM_WORKAROUND_PYTHON_BUG_34780.
  • Use a local copy of dotnet, to avoid interfering with other dotnet instances

Fixes #69860 .

Author: radical
Assignees: radical
Labels:

arch-wasm, test-bug

Milestone: -

@radical radical marked this pull request as ready for review June 7, 2022 07:05
@radical radical requested a review from marek-safar as a code owner June 7, 2022 07:05
@radical radical requested review from lewing, akoeplinger and radekdoulik and removed request for marek-safar June 7, 2022 07:06
@radical radical merged commit 07ee2c7 into dotnet:main Jun 7, 2022
@radical radical deleted the debug-wbt-win branch June 7, 2022 19:40
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] Wasm.Build.Tests timing out on Windows
2 participants