Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Mariner 2.0 as the build image #70111

Closed
wants to merge 8 commits into from

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jun 1, 2022

Context: dotnet/dotnet-buildtools-prereqs-docker#615

TODO task list:

  • Upgrade to clang12 in other docker images. Alpine images need upgrade. Currently have older versions of node too which may cause problems upon upgrade.
  • Compiler crash in in clang12 for mono needs investigation. (@vargaz will take a look initially)
  • Re-specify clang12 as required in build scripts
  • Determine what to do about libc version. Probably need to not use what's on the box and instead link against a specific version/
  • Verify official build
  • Verify PR builds

@ghost ghost assigned mmitche Jun 1, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas
Copy link
Member

jkotas commented Jun 2, 2022

Note that this run just a small fraction of the validation. The main "runtime" pipeline did not run at all. Looks like the changes broke it.

@richlander
Copy link
Member

@mmitche kicked off this build and an official (internal) build concurrently. The official build broke in several places. We'll be looking into that next.

@mmitche
Copy link
Member Author

mmitche commented Jun 2, 2022

Note that this run just a small fraction of the validation. The main "runtime" pipeline did not run at all. Looks like the changes broke it.

I had a typo in the YAML, fixed.

@jkoritzinsky
Copy link
Member

Are we sure that this image will still target the right libc version, or do we need to set up cross targeting with a centos rootfs?

@richlander
Copy link
Member

richlander commented Jun 3, 2022

I raised the same topic in the distro-maintainers group (visible to org members only).

https://github.com/orgs/dotnet/teams/distro-maintainers/discussions/2?from_comment=4#discussion-2-comment-4

@ghost
Copy link

ghost commented Jun 3, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Context: dotnet/dotnet-buildtools-prereqs-docker#615

Author: mmitche
Assignees: mmitche
Labels:

area-Infrastructure

Milestone: -

mmitche and others added 3 commits June 6, 2022 05:34
This one is a different scenario. We can update this one once we've replaced the CentOS 7 baseline image.
@richlander
Copy link
Member

@mmitche -- Can you delete your comment (and this one, too) and put your todo list in the overall issue comment at the top (so it doesn't get lost in the middle)?

@akoeplinger
Copy link
Member

it looks like the mono llvmaot Pri0 Runtime Tests Run Linux x64 leg has a bunch of failures due to

/datadisks/disk1/work/AF8B097E/p/corerun: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /datadisks/disk1/work/AF8B097E/p/corerun)
/datadisks/disk1/work/AF8B097E/p/corerun: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /datadisks/disk1/work/AF8B097E/p/corerun)
/datadisks/disk1/work/AF8B097E/p/corerun: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /datadisks/disk1/work/AF8B097E/p/corerun)
/datadisks/disk1/work/AF8B097E/p/corerun: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /datadisks/disk1/work/AF8B097E/p/corerun)

which is kinda expected when we have libc version mismatches, I think we need to solve those first before we can continue.

@richlander
Copy link
Member

Can you elaborate on that @akoeplinger? Is the issue that the Mono build is brining along or intending to link to a different libc that clang supports?

@akoeplinger
Copy link
Member

akoeplinger commented Jun 10, 2022

No it means that we're building against a newer libc and then try to run on systems with an earlier libc. You can see the same issue on e.g. the coreclr Pri0 Runtime Tests Run Linux x64 checked leg which also runs on ubuntu.1804.amd64.open

@richlander
Copy link
Member

Oh, I see. That.

We knew that we'd have to sort that out pretty soon. That's now, apparently. I general thinking has been to adopt the rootfs approach. We'll talk about that next week.

@danmoseley
Copy link
Member

Does this need to happen for .NET 7 ? @mmitche

@mmitche
Copy link
Member Author

mmitche commented Jul 25, 2022

Does this need to happen for .NET 7 ? @mmitche

I don't think so, @richlander may have a different opinion though.

@agocke
Copy link
Member

agocke commented Jul 25, 2022

Moving this to draft PR since it looks like it's a WIP.

@agocke agocke marked this pull request as draft July 25, 2022 21:01
@richlander
Copy link
Member

Right. Not .NET 7. We'll return to this soon-ish, particularly once main moves to .NET 8.

@ghost ghost closed this Aug 29, 2022
@ghost
Copy link

ghost commented Aug 29, 2022

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants