Support array parameter types of custom attributes in Mono AOT compiler #69759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable in CattrNameArg
…he first one into account, otherwise ignore
vargaz
reviewed
May 25, 2022
vargaz
reviewed
May 25, 2022
…s are constructed during AOT. (dotnet#69077)" since 'load_cattr_value' is not used anymore during AOT compiling This reverts commit d2a7a6d.
…not support building native libraries
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…do not support building native libraries
…erly free array typed arguments
…te_custom_attr_data_args_noalloc
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… arrays are supported
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ivanpovazan
requested review from
lambdageek,
SamMonoRT,
thaystg and
marek-safar
as code owners
ivanpovazan
changed the title
|
Failures seem unrelated. |
vargaz
reviewed
May 31, 2022
vargaz
reviewed
May 31, 2022
vargaz
reviewed
May 31, 2022
vargaz
approved these changes
May 31, 2022
vargaz
reviewed
May 31, 2022
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lambdageek, would you also like to take a look at the latest changes? |
lambdageek
approved these changes
Jun 1, 2022
This was referenced Jul 1, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support array parameter types for custom attributes the following has been done:
MonoCustomAttrValueandMonoCustomAttrValueArrayaddedload_cattr_value_noallocadded - utilises1.mono_reflection_create_custom_attr_data_args_noallocupdated - calls2.MonoDecodeCustomAttrintroduced - holds all the information about decoded custom attributesmono_reflection_create_custom_attr_data_args_noallocupdated to use4- now returns a single structuremono_reflection_free_custom_attr_data_args_noallocintroduced - frees the return structure from5.mono_reflection_create_custom_attr_data_args_noallocupdated - handling fetched named and typed arguments has been adjusted to match newly added types/functionsmono_marshal_get_native_wrapperupdated - native to managed wrapper generation now takes into account custom attributes by updating the method's signatureFixes #52977