-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Docker fixes for the enterprise linux testing pipeline #68913
[release/6.0] Docker fixes for the enterprise linux testing pipeline #68913
Conversation
* attemp to fix up EnterpriseTests * fix text * increase timoeout on build step * fix temeout * add jobs * update job * fix formating * fix name * update server check * restore original resolver before tests * fix path * experiment (cherry picked from commit 9174037)
(cherry picked from commit edb9c49)
…8875) We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/ The image from dotnet-buildtools-prereqs-docker can be used instead. (cherry picked from commit bafae1b)
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsBackport of #65981, #68311 and #68875 to release/6.0 Customer ImpactWe started getting warnings in the build about using images from docker directly, see docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis. Eventually these will be turned into errors and will break the build at that point so we need to backport this before that happens. /cc @dotnet/runtime-infrastructure TestingTested in main and this PR. RiskVery low, it only affects a testing pipeline.
|
/azp run runtime-libraries enterprise-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -60,6 +60,9 @@ services: | |||
hostname: linuxclient | |||
domainname: linux.contoso.com | |||
dns_search: linux.contoso.com | |||
privileged: true | |||
dns: | |||
- 8.8.8.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a backport but I just wanted to make sure that we are ok with using the Google DNS here? cc @GrabYourPitchforks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is there specifically because of https://github.com/dotnet/core-eng/issues/15594
If we can fix the underlying problem and make DNS resolution work in our infrastructure, this could be removed.
enterprise-linux pipeline passed: https://dev.azure.com/dnceng/public/_build/results?buildId=1754267&view=results |
this is a CI-only change so shouldn't need to go through tactics if I remember correctly |
@akoeplinger there are CI failures. Are they related to this change? If not, let me know, and I can merge if you think this is ready. cc @ViktorHofer |
@carlossanlop the failure is unrelated, it's a flaky test that was disabled in main: #65588 |
Backport of #65981, #68311 and #68875 to release/6.0
Customer Impact
We started getting warnings in the build about using images from docker directly, see docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis.
Eventually these will be turned into errors and will break the build at that point so we need to backport this before that happens.
/cc @dotnet/runtime-infrastructure
Testing
Tested in main and this PR.
Risk
Very low, it only affects a testing pipeline.