Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS complaining about missing projects in slns #68488

Merged
merged 9 commits into from
Apr 25, 2022

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 25, 2022

Contributes to #65552

These changes contribute to fixing the broken Visual Studio experience when interacting with out-of-band projects, like Microsoft.Extensions.* in solution files.

The changes are grouped by commits:

  1. Relevant infrastructure changes to avoid references to inbox only libraries.
  2. Update Microsoft.Extensions.* ref projects
  3. Update Microsoft.Extensions.* src projects (just cleaning-up the property that doesn't need to be set anymore)
  4. Update other out-of-band projects that are referenced by Microsoft.Extensions* projects. I plan to submit an extra PR for the remaining ones that aren't part of the Microsoft.Extensions.* graph as I wanted to keep that out of this PR to keep the change minimal.
  5. Update two source files for which an analyzer complained about the missing usage of Span now that System.Memory.dll reaches the compiler.

cc @ericstj as we discussed this in our 1:1 last Thursday.

@ghost
Copy link

ghost commented Apr 25, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #65552

These changes fix the broken Visual Studio experience when interacting with out-of-band projects, like Microsoft.Extensions.* in solution files.

The changes are grouped by commits:

  1. Relevant infrastructure changes to avoid references to inbox only libraries.
  2. Update Microsoft.Extensions.* ref projects
  3. Update Microsoft.Extensions.* src projects (just cleaning-up the property that doesn't need to be set anymore)
  4. Update other out-of-band projects that are referenced by Microsoft.Extensions* projects. I plan to submit an extra PR for the remaining ones that aren't part of the Microsoft.Extensions.* graph as I wanted to keep that out of this PR to keep the change minimal.
  5. Update two source files for which an analyzer complained about the missing usage of Span now that System.Memory.dll reaches the compiler.

cc @ericstj as we discussed this in our 1:1 last Thursday.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this cleanup!

@ViktorHofer ViktorHofer merged commit 09dc0fe into dotnet:main Apr 25, 2022
@ViktorHofer ViktorHofer deleted the ExtensionsAutoReferences branch April 25, 2022 20:06
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Seems like we should have docs somewhere that describe how to maintain references in project files based on various criteria. Do we need to update those?

@ViktorHofer
Copy link
Member Author

We have project docs which are probably the right place to encode rules for references. I will submit a PR to update them.

@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants