-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VS complaining about missing projects in slns #68488
Fix VS complaining about missing projects in slns #68488
Conversation
Remove inbox (Project-)References in out-of-band projects as these projects already build on top of the shared framework (targeting pack).
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsContributes to #65552 These changes fix the broken Visual Studio experience when interacting with out-of-band projects, like Microsoft.Extensions.* in solution files. The changes are grouped by commits:
cc @ericstj as we discussed this in our 1:1 last Thursday.
|
...t.Extensions.Hosting.WindowsServices/src/Microsoft.Extensions.Hosting.WindowsServices.csproj
Show resolved
Hide resolved
src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft.Win32.SystemEvents.csproj
Outdated
Show resolved
Hide resolved
...braries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Seems like we should have docs somewhere that describe how to maintain references in project files based on various criteria. Do we need to update those?
We have project docs which are probably the right place to encode rules for references. I will submit a PR to update them. |
Contributes to #65552
These changes contribute to fixing the broken Visual Studio experience when interacting with out-of-band projects, like Microsoft.Extensions.* in solution files.
The changes are grouped by commits:
cc @ericstj as we discussed this in our 1:1 last Thursday.